[#30797] - [4.0-dev] Add css style for mod_articles_news vertical layout
- Fixed in Code Base
- 1 Oct 2020
- Medium
- Build: 4.0-dev
- # 30797
- Diff
- drmenzelit:4.0-dev-newsflash-vert
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Added css styling for mod_articles_news vertical layout (similar to already merged changes for mod_articles_news horizontal layout).
Summary of Changes
Remove list style and padding for the list
Make image 100% width
Testing Instructions
Install PR and run npm ci or npm run build:css
Create a newsflash module on position sidebar-right or sidebar-left. Select vertical layout.
Actual result BEFORE applying this Pull Request
The articles have a padding on the left and a disc symbol (list style)
Expected result AFTER applying this Pull Request
The articles have no padding on the left and no list style
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Modules Front End |
@paternax Could you go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/30797 and mark your test result by using the "Test this" button, choosing the appropriate result and then submit? Thanks in avdance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30797.
Thanks
I have tested this item
Patch work as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30797.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30797.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
why has this PR 40 Commits?!
Probably my mistake :-(
why has this PR 40 Commits?!
@HLeithner and other maintainers who might check this PR: I was a bit surprised, too. But the changes look OK on GitHub, nothing more than expected, so if this PR here is merged with a squash commit, it should be ok. Probably the branch of this PR was not based on an up to date 4.0-dev branch or a temporarilty modified 4.0-dev branch. That's hard to recover now.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-01 13:45:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
Test successful