[#30789] - [4.0] better handle deprecated bootstrapping Joomla
- Closed
- 25 Feb 2021
- Medium
- Build: 4.0-dev
- # 30789
- Diff
- PhilETaylor:patch-18
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Bootstrapping Joomla using the cms.php file is deprecated
However bootstrap.php and cms.php contain the same content, the only difference is that cms.php has the code to raise a deprecated notice.
HOWEVER the two files are NOT the same, and therefore calling cms.php is NOT THE SAME as calling bootstrap.php as changes are not being made to keep both files in sync (Eg: the following code is missing from cms.php)
// Register the PasswordHash library.
JLoader::register('PasswordHash', JPATH_PLATFORM . '/phpass/PasswordHash.php');Testing Instructions
Try to bootstrap Joomla using cms.php
Try to bootstrap Joomla using bootstrap.php
Actual result BEFORE applying this Pull Request
bootstrap Joomla using cms.php would not register the PasswordHash library.
Expected result AFTER applying this Pull Request
bootstrap Joomla using cms.php would register the PasswordHash library.
AND future changes will be made in bootstrap.php and not forgotten about and synced to cms.php
Documentation Changes Required
None, the deprecation (I assume) is already documented...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Closing as no interest and now conflicts.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-25 14:22:57 |
| Closed_By | ⇒ | PhilETaylor |
Not sure exactly how to bootstrap using different methods - my inexperience. However, I applied the patch and saw that cms.php calls the deprecation notice and then requires bootstrap.php - looks good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30789.