[#3077] - PHP notice: Undefined variable: parts in ajax response
- Closed
- 13 Feb 2014
- Medium
- Build: staging
- # 3077
- Diff
- piotrmocko:patch-12
- Foreign ID 32693
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
After making following fixes
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32693&start=0
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32166&start=0
there is a PHP notice about undefined $parts variable which is clear when you will have a look at the code.
Enable maximal error reporting in global configuration. Make an ajax request to module which name does not have _ and - (also without prefix mod_). You will get PHP notice in JSON response which would break code.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=33121
Maybe better just declare $parts = array(); before line 60. Imho that would be better codestyle.
Then the check would work as it is.
However your solution should work as well.
I will leave this decision for person how will merge this PR.
I will leave this decision for person how will merge this PR.
We usually merge what is provided and don't change code 
Parts is already defined actually (https://github.com/joomla/joomla-cms/blob/master/components/com_ajax/ajax.php#L32). So I don't see why you'd get this error (see this commit: b4c0115)
You are right. Now I found that it was fixed in Joomla 3.2.2 and I created Code tracker item when it was a bug in Joomla 3.2.1
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-02-13 08:50:07 |
Ahh I see :)
To make it easier testing, if you need even you will take a look on code, I have added module on Code Tracker to test it.