PR-4.0-dev ?

Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
25 Sep 2020

Pull Request for Issue joomla/cassiopeia#121.

Summary of Changes

In Blog layouts the intro-image is a link if the param "llink-title" is set. This is an accessibility issue,
This PR removes the linked intro image.

Testing Instructions

In a blog entry select an into-image for an article.
Set the param "link-titles" in the menuItem to this blog.

Actual result BEFORE applying this Pull Request

The image is a link to the article, and the title is also a link to the article.

Expected result AFTER applying this Pull Request

The image is not a link.

Note

An alternative solution would be a new param "link_intro_image", but in this case linking the title must be excluded.

Documentation Changes Required

no

avatar chmst chmst - open - 25 Sep 2020
avatar chmst chmst - change - 25 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2020
Category Layout
avatar brianteeman
brianteeman - comment - 25 Sep 2020

My 2c would be to have a link param with a default option of link_title and the second option of link_intro_image
This would mean you only have one link which satisfies the a11y rule on adjacent identical links.

avatar brianteeman
brianteeman - comment - 25 Sep 2020

But this is definitely a valid solution as well

avatar chmst
chmst - comment - 25 Sep 2020

My 2c would be to have a link param with a default option of link_title and the second option of link_intro_image
This would mean you only have one link which satisfies the a11y rule on adjacent identical links.

Maybe a better solution.

avatar brianteeman
brianteeman - comment - 25 Sep 2020

There is another option if the aim is to make the image and the title both clickable and yet only a single link by borrowing some css from bootstrap
https://getbootstrap.com/docs/4.5/utilities/stretched-link/

Works quite well on my site

avatar adj9 adj9 - test_item - 26 Sep 2020 - Tested successfully
avatar adj9
adj9 - comment - 26 Sep 2020

I have tested this item successfully on a6bb8a5

By inserting the image here and applying the PR, it is not clickable
Schermata 2020-09-26 alle 12 42 55



Confirmed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30769.

avatar ceford ceford - test_item - 26 Sep 2020 - Tested successfully
avatar ceford
ceford - comment - 26 Sep 2020

I have tested this item successfully on a6bb8a5

The patch works as described but for me the image is in the wrong place! It is above the Article title and frankly not obviously part of it. I think it should be closer to the first paragraph like the full article image. It is styled as float-left but its container is full width. But I guess where the Intro image appears is a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30769.

avatar chmst chmst - change - 26 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-26 19:18:59
Closed_By chmst
Labels Added: PR-4.0-dev ?
avatar chmst chmst - change - 26 Sep 2020
Status Closed Pending
avatar chmst chmst - close - 26 Sep 2020
avatar chmst chmst - close - 26 Sep 2020
avatar brianteeman
brianteeman - comment - 26 Sep 2020

@chmst did you mean to close this?

avatar chmst
chmst - comment - 27 Sep 2020

Indeed we should re-think this. It tile is linked AND a readmore is added, then there are two links ... so re-opening this.

avatar chmst
chmst - comment - 28 Sep 2020

@ceford placing the image is indeed another issue and we are working on it.

Add a Comment

Login with GitHub to post a comment