[#30769] - [4.0] [a11y] Do not link intro images
- Pending
- Medium
- Build: 4.0-dev
- # 30769
- Diff
- chmst:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/cassiopeia#121.
Summary of Changes
In Blog layouts the intro-image is a link if the param "llink-title" is set. This is an accessibility issue,
This PR removes the linked intro image.
Testing Instructions
In a blog entry select an into-image for an article.
Set the param "link-titles" in the menuItem to this blog.
Actual result BEFORE applying this Pull Request
The image is a link to the article, and the title is also a link to the article.
Expected result AFTER applying this Pull Request
The image is not a link.
Note
An alternative solution would be a new param "link_intro_image", but in this case linking the title must be excluded.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
But this is definitely a valid solution as well
My 2c would be to have a link param with a default option of link_title and the second option of link_intro_image
This would mean you only have one link which satisfies the a11y rule on adjacent identical links.
Maybe a better solution.
There is another option if the aim is to make the image and the title both clickable and yet only a single link by borrowing some css from bootstrap
https://getbootstrap.com/docs/4.5/utilities/stretched-link/
Works quite well on my site
I have tested this item
By inserting the image here and applying the PR, it is not clickable
Confirmed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30769.
I have tested this item
The patch works as described but for me the image is in the wrong place! It is above the Article title and frankly not obviously part of it. I think it should be closer to the first paragraph like the full article image. It is styled as float-left but its container is full width. But I guess where the Intro image appears is a separate issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30769.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-26 19:18:59 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
| Status | Closed | ⇒ | Pending |
Indeed we should re-think this. It tile is linked AND a readmore is added, then there are two links ... so re-opening this.
My 2c would be to have a link param with a default option of link_title and the second option of link_intro_image
This would mean you only have one link which satisfies the a11y rule on adjacent identical links.