Information Required ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
25 Sep 2020

Summary of Changes

Rename table #__history to #__content_history.

Table name #__history is too common, besides this table is closely related to content.

Original Joomla 3 table #__ucm_history was renamed to #__history and it's really weird.

Let's add more logic into table names while it's not too late for Joomla 4.

Testing Instructions

Install Joomla 4 beta (or update core files in existing installation). Ensure that content history works.

Actual result BEFORE applying this Pull Request

Table #__history exists.

Expected result AFTER applying this Pull Request

Table #__history renamed to #__content_history.

Documentation Changes Required

No.

avatar Denitz Denitz - open - 25 Sep 2020
avatar Denitz Denitz - change - 25 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2020
Category Administration com_admin SQL Postgresql com_content com_contenthistory Installation Libraries
avatar HLeithner
HLeithner - comment - 25 Sep 2020

These changes would suggest that the table belongs to com_content, but this is not the case as every component can use the versioning feature.

avatar 1252spike
1252spike - comment - 25 Sep 2020

Just a thought: Seeing as we call the function "Versions" should this not be called #__versions_history. I'm sure there's a good reason why not, but just a thought.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30766.

avatar Denitz
Denitz - comment - 25 Sep 2020

@HLeithner #__content_types is also used everywhere but it is.

@1252spike Nope, it's used in com_contenthistory, the model name is ContentHistory, the word version is frustrating.

avatar HLeithner
HLeithner - comment - 25 Sep 2020

tbh our complete database structure would need a face lift or more @alikon and @richard67 are pretty much in favor for this but renaming something which is not really wrong and make it wrong isn't a good option ymmv

avatar richard67
richard67 - comment - 25 Sep 2020

@HLeithner I'm not in favour of this.

avatar HLeithner
HLeithner - comment - 25 Sep 2020

@richard67 thought you would like to restructure the database a bit, sorry if I misunderstood this

avatar Fedik
Fedik - comment - 25 Sep 2020

@Denitz do you know a rule "do not touch if it works"? :)

There no much sense in the changes, even if new name sounds better.

avatar brianteeman
brianteeman - comment - 25 Sep 2020

Alpha5 is really not the time to even think about changing core table names

avatar richard67
richard67 - comment - 25 Sep 2020

Alpha5 is really not the time to even think about changing core table names

If it was Alpha5 and not Beta5 I would maybe be ok with it ;-)

avatar ThomasFinnern ThomasFinnern - test_item - 17 Oct 2020 - Tested unsuccessfully
avatar ThomasFinnern
ThomasFinnern - comment - 17 Oct 2020

I have tested this item ? unsuccessfully on d7daae7

Applied patch, Result: "#_history" gone, "#__content_history" exists
Point of concern: Database update structure issued with result error: "missing #_history table"

Tested article history was successful. Changed version version info could be seen in table "#_content_history"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30766.

avatar ThomasFinnern
ThomasFinnern - comment - 17 Oct 2020

Applied patch, Result: "#_history" gone, "#__content_history" exists
Point of concern: Database update structure issued with result error: "missing #_history table"

Tested article history was successful. Changed version version info could be seen in table "#_content_history"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30766.

avatar Denitz Denitz - change - 17 Oct 2020
Labels Added: Information Required ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Administration com_admin SQL Postgresql com_content com_contenthistory Installation Libraries Repository Administration com_admin SQL Postgresql MS SQL com_associations com_categories
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Administration com_admin SQL Postgresql Repository MS SQL com_associations com_categories Administration com_admin SQL Postgresql com_content com_contenthistory Installation Libraries
avatar Denitz Denitz - change - 17 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-17 09:36:43
Closed_By Denitz
avatar Denitz Denitz - close - 17 Oct 2020

Add a Comment

Login with GitHub to post a comment