? ? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
25 Sep 2020

Pull Request for Issue #30761 (comment) .

Summary of Changes

This PR adds the HTML for a missing Table Caption

Testing Instructions

Joomla 4 with "Testing Sample Data"
url =>index.php/article-category-list

Actual result BEFORE applying this Pull Request

Inspect element on shown table.
No table caption is visible

Schermafbeelding 2020-09-25 om 11 23 14

Expected result AFTER applying this Pull Request

Table caption is visible
Schermafbeelding 2020-09-25 om 11 27 04

avatar hans2103 hans2103 - open - 25 Sep 2020
avatar hans2103 hans2103 - change - 25 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2020
Category Front End com_content
avatar infograf768
infograf768 - comment - 25 Sep 2020

String is necessary in frontend
COM_CONTENT_ARTICLES_TABLE_CAPTION="Table of Articles"
Screen Shot 2020-09-25 at 11 54 43

avatar hans2103 hans2103 - change - 25 Sep 2020
The description was changed
avatar hans2103 hans2103 - edited - 25 Sep 2020
avatar hans2103 hans2103 - change - 25 Sep 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 25 Sep 2020

I think you forgot to commit the updated language file

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2020
Category Front End com_content Front End com_content Language & Strings
avatar hans2103
hans2103 - comment - 25 Sep 2020

I think you forgot to commit the updated language file

now I did... I found a language string. Forgot to see that it was in administrator/language, not in language
Now it is

avatar hans2103 hans2103 - change - 25 Sep 2020
Title
Add missing Table Caption
[4.0] Add missing Table Caption
avatar hans2103 hans2103 - edited - 25 Sep 2020
avatar infograf768 infograf768 - test_item - 25 Sep 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Sep 2020

I have tested this item successfully on ca80afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30763.

avatar Quy Quy - test_item - 25 Sep 2020 - Tested successfully
avatar Quy
Quy - comment - 25 Sep 2020

I have tested this item successfully on ca80afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30763.

avatar Quy Quy - change - 25 Sep 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30763.

avatar infograf768 infograf768 - change - 26 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-26 05:43:14
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 26 Sep 2020
avatar infograf768 infograf768 - merge - 26 Sep 2020
avatar infograf768
infograf768 - comment - 26 Sep 2020

Tks.

Add a Comment

Login with GitHub to post a comment