[#30761] - [4.0] Wrap all buttons in btn-group to improve styling
- Fixed in Code Base
- 26 Sep 2020
- Medium
- Build: 4.0-dev
- # 30761
- Diff
- hans2103:patch-8
User tests: Successful: Unsuccessful:
Pull Request for Issue #29504 .
Summary of Changes
This pr will put elements in horizontal line
Testing Instructions
Joomla 4 with "Testing Sample Data"
url => index.php/recipes
Actual result BEFORE applying this Pull Request
See screenshot in #29504
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
Is it useful to display the Filter Button if filter-field is set to hide?
I suggest to modify that part to
<?php if ($this->params->get('filter_field') !== 'hide') : ?>
<div class="com-content-category__filter-submit control-group hidden-xs-up float-right">
<div class="controls">
<button type="submit" name="filter_submit" class="btn btn-primary"><?php echo Text::_('COM_CONTENT_FORM_FILTER_SUBMIT'); ?></button>
</div>
</div>
<?php endif; ?>
Also, for a11y, the table is missing something like
<caption id="captionTable" class="sr-only">
<?php echo Text::_('COM_CONTENT_ARTICLES_TABLE_CAPTION'); ?>,
</caption>
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.
@Formatio-hippocampi
Please wait for @hans2103 to take care of my comments. :)
@infograf768
I don't know if it is useful to display the Filter Button if filter-field is set to hide?
I haven't looked into the functionality of the rendered fields nor buttons. This is not the scope of this PR.
Table Caption out of scope of this PR too... created new pr for it. #30763
I should have been more precise:
The Filter button IS useless when filter-field is set to hide...
| Labels |
Added:
?
|
||
@infograf768 adjusted PR.
Actually you are saying that a PR was needed anyway to solve the display of the button? Not only to fix alignment
| Title |
|
||||||
In a separate PR, filters section shouldn't be hidden when no items.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-26 05:42:15 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
spacing between items is out of scope for this pr