Feeling Lucky
?
?
[#30751] - Backport 2FA edit screen for com_admin
- Fixed in Code Base
- 26 Sep 2020
- Medium
- Build: staging
- # 30751
- Diff
- zero-24:backportComAdmin2fa
User tests: Successful: Unsuccessful:
Summary of Changes
Backport 2FA edit screen for com_admin from 4.x to 3.x too
Testing Instructions
- enable atleast one 2fa plugin
- got to your profile in the backend
- notice that you can not setup 2fa there
- apply this patch (or install the packages from here: https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/30751/downloads/35668)
- got to your profile in the backend
- notice that you now can setup 2fa
- please setup 2fa
- logout
- login with 2fa
- remove 2fa
- logout
- login without 2fa
Actual result BEFORE applying this Pull Request
It is not possible to configure 2fa from com_admin
Expected result AFTER applying this Pull Request
We can configure 2fa from com_admin
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
viocassel
- comment
- 24 Sep 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30751.
richard67
- comment
- 24 Sep 2020
@zero-24 Please fix PHP code style errors reported by drone here https://ci.joomla.org/joomla/joomla-cms/35668/1/3 .
richard67
- comment
- 24 Sep 2020
PR should not be RTC before PHP code style errors are fixed.
| Labels |
Added:
?
|
||
zero-24
- comment
- 24 Sep 2020
Should be fixed now thanks @richard67
zero-24
- comment
- 24 Sep 2020
I have fixed them just a minute ago right?
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 24 Sep 2020
Previous test results were still valid because change after that was only code style of comments => RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30751.
| Status | Ready to Commit | ⇒ | Pending |
richard67
- comment
- 24 Sep 2020
New PHPCS error => back to pennding.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30751.
zero-24
- comment
- 24 Sep 2020
Patched thanks :)
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 24 Sep 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30751.
zero-24
- comment
- 24 Sep 2020
All fine :-)
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-26 14:44:10 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 2522d70
Testet with Joomla 3.9.21. Patch works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30751.