[#30747] - [4.0] Check out improvements related to nullable columns
- Fixed in Code Base
- 24 Sep 2020
- Medium
- Build: 4.0-dev
- # 30747
- Diff
- SharkyKZ:j4/fix/null-check-out
User tests: Successful: Unsuccessful:
Closes #30731.
Summary of Changes
Adds nullable checks for proper handling of 0 value in com_checkin.
Testing Instructions
Set checked_out field value to 0 in one of core tables, e.g by running this query:
UPDATE #__menu SET checked_out=0 WHERE client_id=0
Go to com_checkin.
It would also be good to test that check in still works with 3rd party components that don't use null values.
Actual result BEFORE applying this Pull Request
#__menu table not listed as having checked out items.
Expected result AFTER applying this Pull Request
#__menu table listed as having checked out items and items can be checked in properly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_checkin |
| Labels |
Added:
?
|
||
I have tested this item
Tested successfully in Beta5-dev of 23 September.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747.
I have tested this item
Works as described. Not tested third party components.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30747.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-24 13:37:23 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
RTC
@mahagr Could you test this PR and mark the test result in the issue tracker? Thanks in advance.