[#30734] - [4.0] Remove "cardGrey" chrome
- Fixed in Code Base
- 24 Sep 2020
- Medium
- Build: 4.0-dev
- # 30734
- Diff
- Bakual:4_RemoveCardGreyChrome
User tests: Successful: Unsuccessful:
As written in #30729, the "cardGrey" chrome is basically the same chrome as the "card" (once #30729 is merged) chrome. It just has an added "card-grey" module class.
However the same can be achieved by using the "module class" parameter in the module options and add "card-grey" there.
Summary of Changes
- Removes the chrome layout /templates/cassiopeia/html/layouts/chromes/cardGrey.php
- Changes the styles of the positions which were using it to "card". That is "top-a", "main-top", "main-bottom" and "bottom-a".
Testing Instructions
- Make sure to have the other PR applied as well, otherwise the chrome will not be found and you get some ugly display. Since it's RTC already, chances are high it's merged soon.
- Add the class "card-grey" to the module class parameter in your module
Actual result BEFORE applying this Pull Request
No change as the class is there anyway, now twice.
Expected result AFTER applying this Pull Request
Position gets the darker background only if that class is added to the module, otherwise the regular white background is used.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
The other PR is now merged, so tomorrow in the nightly.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30734.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30734.
| Labels |
Added:
?
?
|
||
That's a good question and I don't know the answer. I just assumed it was a standard Bootstrap class, but when I check the Bootstrap documentation (https://getbootstrap.com/docs/4.0/components/card/) there are no specific colour styling classes for cards.
The BS class which could be used is "bg-light" (from https://getbootstrap.com/docs/4.0/utilities/colors/) which is a tiny bit lighter than "card-grey".
The class "card-grey" seems to be a Cassiopeia class defined in https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/vendor/bootstrap/_card.scss (together with "card-inverse" which seems to be unused).
Maybe that file could be removed - but that's a question for people who know how that stuff works. I just see that it was part of the initial template PR by @C-Lodder
Well, maybe just add something to the "Documentation Changes Required" section of this PR, telling that it needs to document somewhere the Cassiopeia module classes which can be used, and we set the documentation required label. That will not stop this PR from being merged, and we have a reminder somewhere.
Personally I would just remove the cassiopeia specific styling for card-grey and people can use any of the default BS classes instead (or add own ones).
I think it was a custom class: https://github.com/joomla/40-backend-template/blob/master/templates/cassiopeia/scss/vendor/bootstrap/_card.scss#L3-L5
May aswell remove it
I'll leave this PR as is. I can try to remove the SCSS rules in another PR, as soon as I have figured out how to recreate all the compiled CSS files
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-24 19:40:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on a498053
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30734.