NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
21 Sep 2020

Pull Request for Issue # .

Summary of Changes

Update NPM dependencies to latest suitable version with respect to semver.

Mainly it is an update for canisuelite and a few bugfixes or security updates for other packages.

Re-do of PR #30693 .

Thanks @brianteeman for the initial version.

Testing Instructions

Preparation: Make sure that the command shell window you will use to run npm has a sufficient scroll back history so the output of npm will not be lost.

  1. Check the changes of this PR on GitHub. You have to expand the file with the "Load diff" link.
    Verify that there are no unexpected changes resulting in an unresolved reference ("resolved": "").
    Verify that no package will be removed.
  2. Verify that system tests for this PR were passing in Drone.
  3. On a clean 4.0-dev branch, apply the changes of this PR or simply replace the package-lock.json file in the Joomla root folder by the one from this PR.
  4. Run composer install if you haven't done that before.
  5. Run npm ci and watch the output of that command.
  6. Verify that no unusual warnings or errors are issued by npm at the first step when it fetches the external packages before starting the build:js step.
  7. Make a new installation.
  8. Login to backend and check if things work as usual.
  9. Install some kind of sample data to have some frontend content.
  10. Check on frontend if everything works as usual.

Actual result BEFORE applying this Pull Request

npm ci works without unexpected warnings or errors.

Expected result AFTER applying this Pull Request

Same as actual result.

Backend and frontend work as well as before.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 21 Sep 2020
avatar richard67 richard67 - change - 21 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2020
Category NPM Change
avatar richard67 richard67 - change - 21 Sep 2020
The description was changed
avatar richard67 richard67 - edited - 21 Sep 2020
avatar richard67 richard67 - change - 21 Sep 2020
The description was changed
avatar richard67 richard67 - edited - 21 Sep 2020
avatar jwaisner jwaisner - test_item - 27 Sep 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 27 Sep 2020

I have tested this item successfully on ca69671

NPM CI had no errors and no packages were removed.

Confirmed on clean install that no issues occurred.

Installed sample data with no issues.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

avatar alikon alikon - test_item - 27 Sep 2020 - Tested successfully
avatar alikon
alikon - comment - 27 Sep 2020

I have tested this item successfully on ca69671


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

avatar alikon alikon - change - 27 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 27 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

avatar richard67 richard67 - change - 27 Sep 2020
Labels Added: ? ? NPM Resource Changed
avatar HLeithner HLeithner - change - 27 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-27 11:51:53
Closed_By HLeithner
Labels
avatar HLeithner HLeithner - close - 27 Sep 2020
avatar HLeithner HLeithner - merge - 27 Sep 2020
avatar HLeithner
HLeithner - comment - 27 Sep 2020

Thanks

Add a Comment

Login with GitHub to post a comment