?
avatar C-Lodder
C-Lodder
21 Sep 2020

Steps to reproduce the issue

headerMoreBtn.setAttribute('title', 'More Elements');

More Elements should be translated?

avatar C-Lodder C-Lodder - open - 21 Sep 2020
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Sep 2020
avatar brianteeman
brianteeman - comment - 21 Sep 2020

Any idea where/if this is displayed?

avatar infograf768
infograf768 - comment - 21 Sep 2020

It is displayed when window is reduced and we have an ellipsis to dropdown the elements that don't fit anymore in Header.

Screen Shot 2020-09-21 at 10 20 39

So, yes, it should be a constant and translated, in the whole template.

avatar infograf768
infograf768 - comment - 21 Sep 2020

something like
headerMoreBtn.setAttribute('title', Joomla.Text._('JGLOBAL_MORE_ELEMENTS'));

create the string
and then add Text::script('JGLOBAL_MORE_ELEMENTS'); in index.php I guess.

avatar brianteeman
brianteeman - comment - 21 Sep 2020

Thanks @infograf768 I will make a PR - I just couldnt see it in action

avatar C-Lodder C-Lodder - close - 21 Sep 2020
avatar C-Lodder
C-Lodder - comment - 21 Sep 2020

Closing for #30720

avatar C-Lodder C-Lodder - change - 21 Sep 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-09-21 14:45:18
Closed_By C-Lodder

Add a Comment

Login with GitHub to post a comment