User tests: Successful: Unsuccessful:
main change is an update to caniuselite
the rest are bug or security fixes in line with semver
Status | New | ⇒ | Pending |
Category | ⇒ | NPM Change |
from my understanding of the difference between npm ci and npm install this PR is correct and your finding is expected
@brianteeman As I wrote, when using the changed file from this PR on Linux and running npm ci
, I get errors Error: Cannot find module 'is-obj'
. I don't think that's expected. And your PR shows exactly that dependency with empty resvolved
where without your PR there are correct entries.
Please read about the difference between npm install and npm ci
Please read about the difference between npm install and npm ci
I know that difference very well, but maybe you should read a bit npm docs to understand that your PR introduces an unresolved reference, as clearly shown in my screenshot above.
Normally I should just give a negative test result, but I know you would not accept that.
So I shut up at this point and stop to bother you.
Shall someone else handle that.
Meanwhile I think about stop contibuting and leave all teams because I can do better stuff in my spare time than being treated like a little school boy here.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-21 08:16:08 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
NPM Resource Changed
?
|
@brianteeman I would like to see in the furture that you treat people like you to be treated. There is no need that we make it more complicted and less nice as needed. We all do our best here to make progress.
I still dont understand what is wrong with this pr. from everything I read about the difference between npm ci and npm install the changes are expected
As I said, there are lots of Error: Cannot find module 'is-obj'
issued by npm about the unresolved reference to is-obj
, and that is caused by the following change in your PR:
And with my version of the file respective the new PR #30713 that doesn't happen.
I don't have an explanation why that happened with your PR. Maybe something OS specific (I worked on Linux).
It looks a bit as if npm had been run before with a "--no-dev" option or similar, but I don't think that's the case because why should you have done that.
@brianteeman When using the changed file from this PR on Linux and running
npm ci
, I get errorsError: Cannot find module 'is-obj'
.When running
npm install
instead ofnpm ci
, thepackage-lock.json
is changed, and the missing reference tois-obj
is added, see following diff with the file from this PR on the left hand side and the one updated by npm on the right hand side:But before that difference, the comparison shows another one, and that could be the reason why you did not have the problem with unresolved
is-obj
, and I had:Beside these two differences no more differences are shown.
You can download my package-lock from the comparison above here: https://test5.richard-fath.de/package-lock.json.
@wilsonge Any idea?