? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 Sep 2020

Pull Request for Issue #30682

Summary of Changes

Creating the missing strings in front and backend
JCLOSE="Close"
JOK="OK"
JOPEN="Open"

Added the declarations in message.php

The strings are present in /media/vendor/joomla-custom-elements/js/joomla-alert-es5.js

Testing Instructions

Save an article and look at the markup produced for the X icon closing the alert.

Actual result BEFORE applying this Pull Request

jclose

Expected result AFTER applying this Pull Request

Screen Shot 2020-09-19 at 08 57 21

Documentation Changes Required

avatar infograf768 infograf768 - open - 19 Sep 2020
avatar infograf768 infograf768 - change - 19 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2020
Category Administration Language & Strings Layout
d05869c 19 Sep 2020 avatar infograf768 oops
avatar infograf768 infograf768 - change - 19 Sep 2020
Labels Added: ? ?
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 19 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 19 Sep 2020

I have tested this item successfully on d05869c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684.

avatar alikon alikon - test_item - 19 Sep 2020 - Tested successfully
avatar alikon
alikon - comment - 19 Sep 2020

I have tested this item successfully on d05869c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684.

avatar alikon alikon - change - 19 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 19 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30684.

avatar richard67 richard67 - change - 19 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-19 08:40:38
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 19 Sep 2020
avatar richard67 richard67 - merge - 19 Sep 2020
avatar richard67
richard67 - comment - 19 Sep 2020

Thanks!

Add a Comment

Login with GitHub to post a comment