[#30655] - Correct module name in htaccess
- Fixed in Code Base
- 19 Sep 2020
- Medium
- Build: staging
- # 30655
- Diff
- SharkyKZ:j3/fix/htaccess-autoindex
User tests: Successful: Unsuccessful:
Pull Request for Issue #30649.
Summary of Changes
Corrects module name.
Testing Instructions
Code review.
Or test on Apache with module mod_autoindex.c enabled:
Rename htaccess.txt to .htaccess.
Create an empty directory or remove index.html from existing directory.
Open directory in browser.
Actual result BEFORE applying this Pull Request
Directory contents listed.
Expected result AFTER applying this Pull Request
Directory contents not listed.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
| Labels |
Added:
?
?
|
||
Question: will this change also be mentioned in the next update of Joomla in the Post-installation Messages for Joomla CMS?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
Question: will this change also be mentioned in the next update of Joomla in the Post-installation Messages for Joomla CMS?
No idea. Ping @HLeithner @zero-24 .
Only if @SharkyKZ creates a post installation message, alternative we can write it into the release article.
@SniperSister any objections on this.
Only if @SharkyKZ creates a post installation message, alternative we can write it into the release article.
As a reminder, joomla 3.9.21 also included a post-install message to change the .htaccess file.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
Fine for me!
| Status | Ready to Commit | ⇒ | Pending |
I'll look into including a postinstall message. Removing RTC now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql MS SQL Language & Strings |
| Labels |
Added:
?
|
||
Postinstall message added.
I have tested this item
Joomla! 3.9.22-dev+pr.30655 Development [ Amani ] 26-August-2020 08:12 GMT
mysql (5.5.5-10.4.14-MariaDB)
Tested:
mod_autoindex.c
and
post install message
Questing: why this addition as this file can not be updated automatically ?
[EDIT]
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
Questing: why this addition as this file can not be updated automatically ?
I just copied this from the other message. We don't modify existing .htaccess file, users have to do it themselves.
As a reminder, joomla 3.9.21 also included a post-install message to change the .htaccess file.
This message has now disappeared in Joomla 3.9.22 is that the intention?
The 3.9.21 message is added only when updating to 3.9.21. It is not shown on new installations or when running on git clone or updating from nightly to nightly. You'd have to manually to run the SQL script to have it added to the database.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-19 14:52:19 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 8e0a67b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30655.