Feeling Lucky
?
?
[#30653] - [4.0] re-throw the original exception
- Fixed in Code Base
- 16 Sep 2020
- Medium
- Build: 4.0-dev
- # 30653
- Diff
- alikon:patch-81
User tests: Successful: Unsuccessful:
Pull Request for follow up https://github.com/joomla/joomla-cms/pull/30642/files#r488220693.
Summary of Changes
re-throw the original exception for ArticleModel and ContactModel
Testing Instructions
code review
and/or same test as #30642 and for article
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content |
richard67
- comment
- 16 Sep 2020
I have tested this item
It would be better to have separate exception types for the one and the other case (404 and others) instead of checking the code all the time to decide if to re-throw or not.
But that's beyond the scope of this PR.
And for now it is better to re-throw the exception here instead of creating a new, identical one, and so this PR is good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 16 Sep 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-16 10:04:41 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
infograf768
- comment
- 16 Sep 2020
tks
I have tested this item✅ successfully on 443dd9e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30653.