[#30645] - [4.0] [DRAFT] iconclass improvements.
- Closed
- 18 Sep 2020
- Medium
- Build: 4.0-dev
- # 30645
- Diff
- N6REJ:iconPrefix
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Better b/c handling.
Allows for setting custom prefix & icons.
Testing Instructions
compare & inspect icons.
apply pr.
Should be no changes.
install akeeba backup.
akeeba icon should display in dashboard.
no icon changes should be visible.
Expected result
Actual result
Documentation Changes Required
Explain the ability of using prefix. I don't think this is documented currently.
Most of all icons are set through the
LayoutHelper('joomla.icon.iconclass', ['icon' => 'some-kind-of-icon-type'])
adding prefix would become
LayoutHelper('joomla.icon.iconclass', ['icon' => 'some-kind-of-icon-type', 'prefix' => 'myprefix'])
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Title |
|
||||||
Allows for setting custom prefix & icons.
And for Fixed Width Icons, e.g. class="fas fa-skating fa-fw" ?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30645.
Allows for setting custom prefix & icons.
how and where?
don't understand your question. Same way you normally use the layout except add 'prefix' => 'myprefix'
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30645.
Compare screenshots and see the result on the fa-circle icon in column Home
before PR
after PR
The example above comes from ./administrator/components/com_menu/tmpl/items/default.php and seems to fail when only 'fa-circle' if provided instead of 'fas fa-circle'.
This PR should also work in case fas is forgotten.
After PR
Missing Akeeba icon
Thanks guys, I'll fix it tomorrow
| Title |
|
||||||
| Title |
|
||||||
Missing Akeeba icon
Joomla 4: before and after PR
Joomla 3: for comparison
The missing icon was not caused by this PR.
administrator/components/com_akeeba/Toolbar/Toolbar.php line 350: $icon = 'akeeba-j4';
When I change the line to $icon = ' icon-akeeba-j4'; I can see the missing icon.
It seems that Akeeba is assuming the presence of Icomoon. This icon library has been replaced by Font Awesome in J4.
But due to backwards compatibility during J4 the icon should be shown.
Tough one to solve I guess
Tough one to solve I guess
Not really - revert all of these useless changes to the icons
The missing icon was not caused by this PR.
That's right.
Allows for setting custom prefix & icons.
how and where?
don't understand your question. Same way you normally use the layout except add 'prefix' => 'myprefix'
If that's what you meant by "allow custom prefix" etc then its no different to before this PR - you have to override the layout
Can you please please explain what the benefit is of this code. AFAICT the only B/C issue this fixes is one you introduced in another proposed pr and other than that its just change for change sake
@sandewt just found out that an earlier merged PR caused the issue.
Not completely true.
I tried something, this seems to work for Joomla and Akeeba before patch #30645:
But is of course not a good solution!
//$icon = stristr($icon, "joomla") ? str_ireplace("joomla", "fab fa-joomla", $icon) : "fas fa-" . $icon; // skipp this line !?
?>
<h1 class="page-title">
<span class="icon-<?php echo $icon; ?>" aria-hidden="true"></span>
<span class="<?php //echo $icon; ?>" aria-hidden="true"></span>
<?php echo $displayData['title']; ?>
</h1>
| Category | Layout | ⇒ | Repository Administration |
you probably didnt mean to update 578 files by including akeeba backup in this PR or to commit your on .gitignore file
you probably didnt mean to update 578 files by including akeeba backup in this PR or to commit your on .gitignore file
ugh
| Category | Repository Administration | ⇒ | Layout |
Can you please please explain what the benefit is of this code. I am not alone in failing to see any point in this PR. If you cannot explain the benefits etc then its just change for changes sake.
we're rethinking the entire icon handling so closing all pr's for now.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-18 06:55:55 |
| Closed_By | ⇒ | N6REJ |
Good
See PR #30677
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30645.
how and where?