PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
14 Sep 2020

Pull Request for Issue #30628

Summary of Changes

Dispatcher was allowing only superuser to use module frontendediting

Testing Instructions

Set Global Configuration to allow Frontend editing for modules
In Modules Options, set administrator permissions for frontend editing to Allowed.
Screen Shot 2020-09-13 at 18 08 07

In frontend, log with a user set as administrator.
Click on the edit icon for a module

Screen Shot 2020-09-13 at 18 09 32

Patch and test again

Actual result BEFORE applying this Pull Request

403 You don't have permission to access this. Please contact a website administrator if this is incorrect.

Expected result AFTER applying this Pull Request

Module is displayed for editing

avatar infograf768 infograf768 - open - 14 Sep 2020
avatar infograf768 infograf768 - change - 14 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2020
Category Front End com_config
avatar ChristineWk ChristineWk - test_item - 14 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Sep 2020

I have tested this item successfully on e79634f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar Formatio-hippocampi Formatio-hippocampi - test_item - 14 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 14 Sep 2020

I have tested this item successfully on e79634f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar infograf768
infograf768 - comment - 14 Sep 2020

Please do not set as RTC as @SharkyKZ is correct but I don't know the solution.

avatar infograf768 infograf768 - change - 14 Sep 2020
Labels Added: PR-4.0-dev
avatar infograf768
infograf768 - comment - 14 Sep 2020

I modified the PR to introduce a specific conditional for the module editing, separating it from the general permissions.
It solves that issue but I discovered some other issues for template editing and site administrator link.

avatar ChristineWk ChristineWk - test_item - 14 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Sep 2020

I have tested this item successfully on ed0e614

also with a custom modul


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar Formatio-hippocampi Formatio-hippocampi - test_item - 14 Sep 2020 - Tested unsuccessfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 14 Sep 2020

I have tested this item 🔴 unsuccessfully on ed0e614

Open Module in Frontend works. Click on Save, Save & Closeor Cancel of Module show 403 You don't have permission to access this. Please contact a website administrator if this is incorrect.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar ChristineWk
ChristineWk - comment - 14 Sep 2020

@Formatio-hippocampi
ohh (:- Tried also now to Save etc. Confirm. Hv to cancel successful ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar ChristineWk ChristineWk - test_item - 14 Sep 2020 - Tested unsuccessfully
avatar ChristineWk
ChristineWk - comment - 14 Sep 2020

I have tested this item 🔴 unsuccessfully on ed0e614


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30636.

avatar infograf768
infograf768 - comment - 14 Sep 2020

grrr

avatar infograf768
infograf768 - comment - 14 Sep 2020

Closing as this is not the solution.

avatar infograf768 infograf768 - change - 14 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-14 16:30:40
Closed_By infograf768
avatar infograf768 infograf768 - close - 14 Sep 2020

Add a Comment

Login with GitHub to post a comment