Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30633] - [4.0][DRAFT] Begin allowing for other icon families

? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
13 Sep 2020

Pull Request for Issue # .

Summary of Changes

Allows for custom icon prefix and fixed width

Testing Instructions

inspect icons. Verify they display same as before.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

explain how to use icon layout

avatar N6REJ N6REJ - open - 13 Sep 2020
avatar N6REJ N6REJ - change - 13 Sep 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2020
Category ⇒ Layout
avatar brianteeman
brianteeman - comment - 13 Sep 2020

fw stands for "fixed width" not "wide"
https://fontawesome.com/how-to-use/on-the-web/styling/fixed-width-icons

avatar hans2103
hans2103 - comment - 14 Sep 2020

@N6REJ smart
But I see two things:

  • when $icon === $icon and HTML = false the wide will not be set.
  • you are setting iconWide on almost every icon and when html !== false you set iconWide again. That will result in double rendering of fa-fw
avatar N6REJ
N6REJ - comment - 14 Sep 2020

@hans2103 and I discussed this in the team and we're going to do it in another pr we're working on.

avatar N6REJ N6REJ - close - 14 Sep 2020
avatar N6REJ N6REJ - change - 14 Sep 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-09-14 10:10:51
Closed_By ⇒ N6REJ
Labels Added: ?

Add a Comment

Login with GitHub to post a comment