J4 Frontend Template PR-4.0-dev RTC

Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Sep 2020

Pull Request for Issue # .

Summary of Changes

Change order of options of the "Fluid Layout" toggle in Cassiopeia's template style options so it is like for other toggle buttons.

Testing Instructions

Check in the template style's advanced options of Cassiopeia how the toggle buttons are coloured when being not enabled and when being enabled.

Actual result BEFORE applying this Pull Request

When not enabled, "Fluid Layout" is coloured green (see red mark in screenshot below), while other toggles are grey when not being enabled (see green mark below):
j4-cassiopeia-fluid_1

When enabled, "Fluid Layout" is coloured grey (see red mark in screenshot below), while other toggles are green when being enabled (see green mark below):
j4-cassiopeia-fluid_2

Expected result AFTER applying this Pull Request

Grey when "Fluid Layout" is not enabled, i.e. static layout is used:
j4-cassiopeia-fluid_3

Green when "Fluid Layout" is enabled:
j4-cassiopeia-fluid_4

Documentation Changes Required

None.

avatar richard67 richard67 - open - 13 Sep 2020
avatar richard67 richard67 - change - 13 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2020
Category Front End Templates (site)
avatar richard67 richard67 - change - 13 Sep 2020
Labels Added: PR-4.0-dev J4 Frontend Template
avatar richard67 richard67 - change - 13 Sep 2020
Title
Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options
[4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options
avatar richard67 richard67 - edited - 13 Sep 2020
avatar richard67 richard67 - change - 13 Sep 2020
Easy No Yes
avatar chmst
chmst - comment - 13 Sep 2020

It works as you say, so tested successfully.

In my opinion it is always an error to have switches with another label than yes/no or show/hide. But this is not in scope of tihs PR.

avatar chmst chmst - test_item - 13 Sep 2020 - Tested successfully
avatar chmst
chmst - comment - 13 Sep 2020

I have tested this item successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

avatar ChristineWk ChristineWk - test_item - 13 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 13 Sep 2020

I have tested this item successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

avatar richard67 richard67 - change - 13 Sep 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

avatar hans2103 hans2103 - test_item - 13 Sep 2020 - Tested successfully
avatar hans2103
hans2103 - comment - 13 Sep 2020

I have tested this item successfully on c27e6fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.

avatar Quy Quy - change - 13 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-13 15:06:04
Closed_By Quy
Labels Added: RTC
avatar Quy Quy - close - 13 Sep 2020
avatar Quy Quy - merge - 13 Sep 2020
avatar Quy
Quy - comment - 13 Sep 2020

Thanks.

avatar richard67
richard67 - comment - 13 Sep 2020

Thanks too.

Add a Comment

Login with GitHub to post a comment