[#30629] - [4.0] Fix colouring of "Fluid Layout" toggle in Cassiopeia's template style options
- Fixed in Code Base
- 13 Sep 2020
- Medium
- Build: 4.0-dev
- Easy Test
- # 30629
- Diff
- richard67:4.0-dev-fix-cassiopeia-template-style-fluid-toggle-colors
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Change order of options of the "Fluid Layout" toggle in Cassiopeia's template style options so it is like for other toggle buttons.
Testing Instructions
Check in the template style's advanced options of Cassiopeia how the toggle buttons are coloured when being not enabled and when being enabled.
Actual result BEFORE applying this Pull Request
When not enabled, "Fluid Layout" is coloured green (see red mark in screenshot below), while other toggles are grey when not being enabled (see green mark below):
When enabled, "Fluid Layout" is coloured grey (see red mark in screenshot below), while other toggles are green when being enabled (see green mark below):
Expected result AFTER applying this Pull Request
Grey when "Fluid Layout" is not enabled, i.e. static layout is used:
Green when "Fluid Layout" is enabled:
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30629.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-13 15:06:04 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks.
Thanks too.
It works as you say, so tested successfully.
In my opinion it is always an error to have switches with another label than yes/no or show/hide. But this is not in scope of tihs PR.