? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
12 Sep 2020

This code should work as it is but it's in draft as I need to create some dummy plugins and modules for people to test with.

Summary of Changes

Fixes Joomla database checker for 3rd party modules and plugins

Testing Instructions

Install the following 4 sample extensions:

test_module_admin_update_files.zip
test_module_site_update_files.zip
test_plugin_update_files.zip
test_plugin_wrong_files.zip

there's two plugins, a backend module and a frontend module. Before patch the database checker page will give an exception:

Screenshot 2020-09-14 at 21 52 18

After the patch the checker will show 3 of the extensions (one plugin and two modules) and won't list a plugin that is in an 'unexpected location' (see note on doc required change below if you're interested as to why)

Screenshot 2020-09-14 at 21 52 45

Documentation Changes Required

We need to document that for database fixer to work updates must exist in the format updates/mysql or updates/postgresql (at any level) - if you have mysql/updates as a folder structure the extension will be ignored by the schema checker.

avatar wilsonge wilsonge - open - 12 Sep 2020
avatar wilsonge wilsonge - change - 12 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2020
Category Administration com_installer Libraries
avatar wilsonge wilsonge - change - 12 Sep 2020
Title
Fix extension SQL check for generic components, modules and plugins
[4.0] Fix extension SQL check for generic components, modules and plugins
avatar wilsonge wilsonge - edited - 12 Sep 2020
avatar wilsonge
wilsonge - comment - 12 Sep 2020

Marking as release blocker as this stops the database fixer from working completely when any plugin or module that has a SQL update file is installed

avatar wilsonge wilsonge - change - 12 Sep 2020
Labels Added: ? ?
avatar wilsonge wilsonge - change - 13 Sep 2020
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 14 Sep 2020
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 14 Sep 2020
Labels Added: ?
Removed: ?
ede7746 14 Sep 2020 avatar wilsonge PHPCS
avatar wilsonge wilsonge - change - 14 Sep 2020
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 14 Sep 2020
The description was changed
avatar wilsonge wilsonge - edited - 14 Sep 2020
avatar wilsonge wilsonge - change - 14 Sep 2020
The description was changed
avatar wilsonge wilsonge - edited - 14 Sep 2020
avatar wilsonge
wilsonge - comment - 14 Sep 2020

Examples uploaded. Ready to rumble I hope

avatar N6REJ N6REJ - test_item - 15 Sep 2020 - Tested successfully
avatar N6REJ
N6REJ - comment - 15 Sep 2020

I have tested this item successfully on ede7746


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626.

avatar richard67 richard67 - test_item - 15 Sep 2020 - Tested successfully
avatar richard67
richard67 - comment - 15 Sep 2020

I have tested this item successfully on ede7746


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626.

avatar richard67 richard67 - change - 15 Sep 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30626.

avatar wilsonge wilsonge - change - 15 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-15 10:44:22
Closed_By wilsonge
Labels Added: ? ?
Removed: ?
avatar wilsonge wilsonge - close - 15 Sep 2020
avatar wilsonge wilsonge - merge - 15 Sep 2020
avatar wilsonge
wilsonge - comment - 15 Sep 2020

Thanks guys!

Add a Comment

Login with GitHub to post a comment