? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
11 Sep 2020

Pull Request for Issue #26157 (comment).

Summary of Changes

Get categories from component instead of using deprecated JCategories::getInstance().

Testing Instructions

Create a custom field for articles.
Assign to Uncategorised category.
Create an article. Select Uncategorised category.
Check that custom field appears in form.

Expected result AFTER applying this Pull Request

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 11 Sep 2020
avatar SharkyKZ SharkyKZ - change - 11 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2020
Category Administration com_fields
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 11 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 11 Sep 2020

I have tested this item successfully on 827a8d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613.

avatar chmst chmst - test_item - 11 Sep 2020 - Tested successfully
avatar chmst
chmst - comment - 11 Sep 2020

I have tested this item successfully on 827a8d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613.

avatar Quy Quy - change - 11 Sep 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30613.

avatar wilsonge
wilsonge - comment - 12 Sep 2020

Will this still work on J3 style components that don't use services?

avatar SharkyKZ
SharkyKZ - comment - 12 Sep 2020

It should. Legacy components implement Joomla\CMS\Categories\CategoryServiceInterface.

class LegacyComponent
implements ComponentInterface, MVCFactoryServiceInterface, CategoryServiceInterface, FieldsServiceInterface, RouterServiceInterface,
TagServiceInterface
{

Works with Weblinks 3.7.0.

avatar wilsonge wilsonge - close - 12 Sep 2020
avatar wilsonge wilsonge - merge - 12 Sep 2020
avatar wilsonge wilsonge - change - 12 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-12 20:24:44
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 12 Sep 2020

Cool - thanks!

Add a Comment

Login with GitHub to post a comment