Feeling Lucky
?
?
[#30608] - Fix call_user_func_array() arguments on PHP 8
- Fixed in Code Base
- 14 Nov 2020
- Medium
- Build: staging
- # 30608
- Diff
- SharkyKZ:j3/php8/event
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Changes second argument of call_user_func_array() from associative to indexed array. Before PHP 8 both types of arrays work the same but on PHP 8 associative arrays are interpreted as "named parameters". In our case this causes code to break.
Testing Instructions
Use PHP 8.
Open article form.
Actual result BEFORE applying this Pull Request
Error:
Unknown named parameter $name
Expected result AFTER applying this Pull Request
No errors, editor and editor buttons appear correctly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
alikon
- comment
- 24 Sep 2020
my php images is based on https://github.com/devilbox/docker-php-fpm-8.0
SharkyKZ
- comment
- 2 Oct 2020
Just tried with RC1. Issue still exists.
alikon
- comment
- 7 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30608.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 17:59:38 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 14 Nov 2020
Tested successfully, thanks
unable to replicate on PHP Version 8.0.0-dev