?
avatar SharkyKZ
SharkyKZ
9 Sep 2020

What needs to be fixed

There are some strings with missing or invalid variable format specifiers. Some examples:

INSTL_DATABASE_ERROR_CREATE="%এস ডেটাবেজটি তৈরির সময় কোন একটা সমস্যা হচ্ছে।<br />ব্যবহারকারীর হয়তো ডেটাবেজ তৈরী করার জন্য প্রয়োজনীয় অনুমতি নাই। Joomla ইন্সটল করার আগেই হয়তো এই ডেটাবেজ তৈরী করে নিতে হবে।"

INSTL_DATABASE_COULD_NOT_CONNECT="डेटाबेस से कनेक्ट नहीं कर सका.:% S संबंधक संख्या लौटे"

INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_CONTENT_LANGUAGE="Joomla không thể tự động tạo ra nội dung cho ngôn ngữ %"

This doesn't cause an issue but space should probably be after HTTP:

JLIB_JS_AJAX_ERROR_OTHER="JSON деректерін алу кезінде қате пайда болды: HTTP% s күй коды."

Why this should be fixed

Passing these to sprintf() results in invalid strings being outputted and causes errors on PHP 8.

How would you fix it

Add missing format specifiers.

Side Effects expected

No.

avatar SharkyKZ SharkyKZ - open - 9 Sep 2020
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Sep 2020
avatar Bakual
Bakual - comment - 9 Sep 2020

That should be told the respective translation teams as they need to take care of it in their source files.
@infograf768 Do you want to take care of this?

avatar infograf768
infograf768 - comment - 9 Sep 2020

will look what we can do

avatar infograf768 infograf768 - change - 10 Sep 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-09-10 05:50:22
Closed_By infograf768
avatar infograf768 infograf768 - close - 10 Sep 2020
avatar infograf768
infograf768 - comment - 10 Sep 2020

Please test
#30609
closing as we have a patch

Add a Comment

Login with GitHub to post a comment