[#30600] - [4.0] Remove unused model class
- Fixed in Code Base
- 15 Sep 2020
- Medium
- Build: 4.0-dev
- # 30600
- Diff
- SharkyKZ:j4/php8/cmsmodel
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Removes unused Joomla\Component\Config\Site\Model\CmsModel class which now also errors on PHP 8 due to method signature mismatch.
Testing Instructions
Code review?
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
| Title |
|
||||||
It's possible. But to maintain PHP 8 compatibility we'd have to either update the method signatures or break class inheritance again, both of which are B/C breaks for anyone extending the class. So I think it's more painless to remove it and have developers extend Joomla\CMS\MVC\Model\BaseDatabaseModel instead. We have no way of testing if the model's code works in core anyways.
I have tested this item
I looked for CmsModel in php files throughout the code and found only one instance in CmsModel.php. I think this is a successful test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.
Belay that last test - after applying the patch the class is still in the code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.
RTC?
@wilsonge Does anything speak against RTC with respect to the comment above?
No we should be good as it's part of the component. Our B/C promise has never extended into components
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-15 08:42:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Is it possible that 3rd party extension use this model?