? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
9 Sep 2020

Pull Request for Issue # .

Summary of Changes

Removes unused Joomla\Component\Config\Site\Model\CmsModel class which now also errors on PHP 8 due to method signature mismatch.

Testing Instructions

Code review?

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 9 Sep 2020
avatar SharkyKZ SharkyKZ - change - 9 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2020
Category Front End com_config
avatar SharkyKZ SharkyKZ - change - 9 Sep 2020
Title
[4.0] Remove unused model
[4.0] Remove unused model class
avatar SharkyKZ SharkyKZ - edited - 9 Sep 2020
avatar chmst
chmst - comment - 9 Sep 2020

Is it possible that 3rd party extension use this model?

avatar SharkyKZ
SharkyKZ - comment - 9 Sep 2020

It's possible. But to maintain PHP 8 compatibility we'd have to either update the method signatures or break class inheritance again, both of which are B/C breaks for anyone extending the class. So I think it's more painless to remove it and have developers extend Joomla\CMS\MVC\Model\BaseDatabaseModel instead. We have no way of testing if the model's code works in core anyways.

avatar ceford ceford - test_item - 10 Sep 2020 - Tested successfully
avatar ceford
ceford - comment - 10 Sep 2020

I have tested this item successfully on c27d011

I looked for CmsModel in php files throughout the code and found only one instance in CmsModel.php. I think this is a successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.

avatar ceford
ceford - comment - 10 Sep 2020

Belay that last test - after applying the patch the class is still in the code.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.

avatar chmst chmst - test_item - 10 Sep 2020 - Tested successfully
avatar chmst
chmst - comment - 10 Sep 2020

I have tested this item successfully on c27d011


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30600.

avatar Formatio-hippocampi
Formatio-hippocampi - comment - 11 Sep 2020

RTC?

avatar richard67
richard67 - comment - 15 Sep 2020

@wilsonge Does anything speak against RTC with respect to the comment above?

avatar wilsonge
wilsonge - comment - 15 Sep 2020

No we should be good as it's part of the component. Our B/C promise has never extended into components

avatar wilsonge wilsonge - change - 15 Sep 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-15 08:42:21
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Sep 2020
avatar wilsonge wilsonge - merge - 15 Sep 2020
avatar wilsonge
wilsonge - comment - 15 Sep 2020

Thanks!

Add a Comment

Login with GitHub to post a comment