I have tested this item ? unsuccessfully on 741f9ca

The accessibility changes you made are completely wrong

1. never add role=button to a link
2. incorrect usage of aria-live (and not needed)

The accessibility changes you made are completely wrong
never add role=button to a link
incorrect usage of aria-live (and not needed)

It was useless to set unsuccessful as I noted in the description TO CHECK please as I'm not a specialist.

Thank you for your comment. Getting rid of these 2 aspects. Is there anything else?

I cannot replicate your screenshots - looks like you might be missing a class on the "tooltip" div

Also because the link is called edit and the tooltip begins with edit it is announced by a screenreader as
Edit Edit ....

NPM ci is necessary.

Class is not missing, role tooltip is a class de facto

// set up hidden tooltip
[role="tooltip"]:not(.show) {
  z-index: $zindex-tooltip;
  display: none;
  max-width: 100%;
  padding: .5em;
  margin: .5em;
  color: $black;
  background: $white-offset;
  border: 1px solid $gray-600;
  border-radius: $border-radius;
  box-shadow: 0 0 .5rem rgba(0,0,0,.8);

  &[id^=editarticle-] {
    margin-inline-start: -10em;
  }

  [dir=ltr] & {
    text-align: left;
  }

  [dir=rtl] & {
    text-align: right;
  }
}

but it looks like I can't apply anymore this .diff in eclipse for the 3 layouts files
Checking that aspect now here.

Can you explain

Also because the link is called edit and the tooltip begins with edit it is announced by a screenreader as

Not sure what you mean by the link is called edit. Can you explain? And what it should be?

I see now why this PR does ot apply anymore here..
#30543 was merged

The git apply issue solved itself here.. :)

Also because the link is called edit and the tooltip begins with edit it is announced by a screenreader as Edit Edit ....

Got it now. I don't think it is a big deal.

That would be a decision by the accessibility team

Stefan made suggestions. Will modify stuff shortly.

Modified with various improvements. aria-hidden true. Simplified tooltips.
Now we get:

I have tested this item ✅ successfully on f9fd8ed

I see the simplified tip in all three situations

Don't know why but the role=tooltip css is present in my unminified css file but NOR in the minified one

@brianteeman did you use the patchtester? I have the same effect, but think that this not related to the PR. The PR looks great I will test as soon as required the changes are comitted.

@chmst I did but I cant see how that would make a difference. If the code is present in the non-minified css then the patch has worked

found the problem - its not related to patchtester - creating a seperate issue for it

I have tested this item ✅ successfully on f9fd8ed

Marking as successful as the minification issue is unrelated to the actual pr

Don't know why but the role=tooltip css is present in my unminified css file but NOR in the minified one

RTC as last changes were small cs corrections.

Thanks!

@wilsonge do we need to document the change that the helper function got removed in the upgrade guide?

Will now make similar changes for the Edit Contact.

@laoneo I guess it can't hurt to document it although I suspect it's a touch overkill