[#30585] - [4.0] fix color selector box too small issue
- Fixed in Code Base
- 8 Sep 2020
- Medium
- Build: 4.0-dev
- # 30585
- Diff
- pdkpavankumar:color-selector-box
User tests: Successful: Unsuccessful:
Pull Request for Issue #29954 .
#29954
Summary of Changes
Increased the height of the color box to match input box
Testing Instructions
safari on Mac
Edit atum template style in Joomla admin
Colour Settings tab
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item
Ok on Safari, Firefox, Chrome
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
Restarted drone
@pdkpavankumar Our scss code style checker fails with errors, see https://ci.joomla.org/joomla/joomla-cms/35279/1/22 for the details. Could you check and fix that? If you need help with that, let us know here. Thanks in advance.
| Labels |
Added:
?
?
|
||
@richard67 i have fixed the sass stylelint error
@pdkpavankumar Thanks for the quick fix. By the way, if you want to check results of such tests like code style or system tests yourself, you can find a section with these tests at the bottom of each pull request. If all tests were successful this section is hidden but can be expanded with a link "Show all checks". Then right beside each check is a link "Details", which leads then to the log of the test.
| Status | Ready to Commit | ⇒ | Pending |
Reset to pending as there was a change
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
@pdkpavankumar And by the way: Thank you very much for your first pull request (PR) for the Joomla CMS.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
I have tested this item
Lesson: never set RTC when drone is still working or fails, even if it looks unrelated to the PR.. ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
| Status | Pending | ⇒ | Ready to Commit |
RTC now for good. Hopefully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-08 14:10:14 |
| Closed_By | ⇒ | laoneo |
Nice one, thanks!
I have tested this item✅ successfully on 200704e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.