Feeling Lucky
?
?
?
[#30582] - Remove duplicate minus sign in Profiler
- Fixed in Code Base
- 14 Nov 2020
- Medium
- Build: staging
- # 30582
- Diff
- SharkyKZ:j3/impr/profiler-buffer
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Alternative to #29353 and also fixes errors on PHP 8.
Summary of Changes
Removes double minus sign when storing time and memory in Profiler. This fixes type error on PHP 8 and notices on PHP 7.
Testing Instructions
Enable debug on PHP 8.
Actual result BEFORE applying this Pull Request
round(): Argument #1 ($number) must be of type int|float, string given
C:\wamp\www\joomla-cms-3\plugins\system\debug\debug.php:716
Expected result AFTER applying this Pull Request
No errors.
Documentation Changes Required
Don't think so.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
jwaisner
- comment
- 13 Sep 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 13 Sep 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 15:06:04 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 14 Nov 2020
Thanks
I have tested this item✅ successfully on 24a5e42
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30582.