? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
2 Sep 2020

Pull Request for Issue # .

Summary of Changes

makes all info-block icons fixed with so things line up.

Testing Instructions

install "blog" sample data.
go to administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=103

change red options to match as shown.
image

go to "about" page in front end..
image

verify icons show.
image

verify icons & text line up.
image

inspect icons to be sure the icon class ends in "fa-fw"
image

Actual result BEFORE applying this Pull Request

Content & Icons didn't line up
image

Expected result AFTER applying this Pull Request

everything is visually lined up.

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 2 Sep 2020
avatar N6REJ N6REJ - change - 2 Sep 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2020
Category ⇒ Layout Libraries
avatar N6REJ N6REJ - change - 2 Sep 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2020
Category Layout Libraries ⇒ Layout
avatar hans2103 hans2103 - test_item - 2 Sep 2020 - Tested successfully
avatar hans2103
hans2103 - comment - 2 Sep 2020

I have tested this item ✅ successfully on 8decde9

Every icon has same width now. Alignment will be improved by this PR. Nice!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543.

avatar paternax paternax - test_item - 2 Sep 2020 - Tested successfully
avatar paternax
paternax - comment - 2 Sep 2020

I have tested this item ✅ successfully on 8decde9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543.

avatar brianteeman
brianteeman - comment - 2 Sep 2020

thinking out aloud - any reason not to just make all icons fixes width

avatar sandewt
sandewt - comment - 4 Sep 2020

thinking out aloud - any reason not to just make all icons fixes width

Recommended in any case for vertical menus with different icons.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543.

avatar infograf768
infograf768 - comment - 4 Sep 2020

Let’s wait for @wilsonge reply about the use of fontawesome in front end before merging this.

avatar N6REJ
N6REJ - comment - 4 Sep 2020

@infograf768 it can be merged as if it needs to change the entire core of how icons function will need to change.

avatar Quy Quy - change - 4 Sep 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 4 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543.

avatar Quy Quy - change - 6 Sep 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-09-06 11:35:11
Closed_By ⇒ Quy
Labels Added: ?
avatar Quy Quy - close - 6 Sep 2020
avatar Quy Quy - merge - 6 Sep 2020
avatar Quy
Quy - comment - 6 Sep 2020

Thanks.

Add a Comment

Login with GitHub to post a comment