[#30537] - [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty
- Fixed in Code Base
- 4 Sep 2020
- Medium
- Build: 4.0-dev
- # 30537
- Diff
- infograf768:4.0_multilingualstatus_sef_error
User tests: Successful: Unsuccessful:
Summary of Changes
As title says
Testing Instructions
Multilingual site.
Until #30496 make its way to J4, easier way to test is
-
Enter only symbols like
%or&in the URL Language Code field -
Unicode Alias being set to No in Global Configuration.
Example while admin language is en-GB, enter the multibytes Greek charactersαω
In these cases there is not yet any error when saving the Content Language, but the URL Language Code (sef) is empty.
In any case, an error may have happened and the sef may be empty in the db.
Patch, modify and save the URL Language Code of one of the Content Languages to save it empty as explained above.
Display the Multilingual Status module modal window.
Expected result AFTER applying this Pull Request
The multilingual status module will now display an error.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages Language & Strings |
As I stated in the description, it may also happen if the db is corrupted and the sef column is empty for a reason or another.
We have no example of this ever happening on the forums. So it is just to be on the safe side.
I think a postinstall would be excessive.
Ok, fine for me.
I have tested this item
Used "&" in URL Language Code > the multilingual status module display an error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30537.
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30537.
| Status | Pending | ⇒ | Ready to Commit |
RTC as the last change is only a small modification of the string value.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30537.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-04 18:21:34 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merging thanks.
hmm should's such a warning not better be a postinstall? given that this is an error that can only happen on sites older than 3.9.22 right?