[#30529] - Update default_updated_files.php
- Closed
- 10 Sep 2020
- Medium
- Build: 4.0-dev
- # 30529
- Diff
- Razzo1987:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #30494 .
Summary of Changes
Change
<?php echo base64_decode($value->hash_id); ?> with <?php echo \base64_decode($value->hash_id); ?> to circumvent the recognition of "echo base64_decode" as a virus in cPanel (false positive).
Testing Instructions
- Try to upload in cPanel file manager the compiled zip file (NO PATCH TESTER) from https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30529/downloads/35140
- I don't know how to test
default_updated_files.phpfunctionality
Actual result BEFORE applying this Pull Request
- Uploading alert a Virus in the ZIP file:
- Test of
default_updated_files.php
Expected result AFTER applying this Pull Request
- Uploading success:
- Test of
default_updated_files.php
Documentation Changes Required
cPanel version affected
86.0.22
88.0
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
if that bad check can be tricked by inserting a slash then its not just a bad check its a terrible check
@brianteeman you're absolutely right!
What worries me is the amount of users who may be unable to install Joomla due to this problem
To the best of my knowledge this is NOT a cpanel issue but related to your hosts implementation of http://www.rfxn.com/projects/linux-malware-detect/
Closing as this is not the correct fix. Please post in https://forum.joomla.org/ to see if others are experiencing the same issue. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-10 23:17:31 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Information Required
?
|
||
I uploaded the current Nightly Build and the one created by your PR.
Both upload successful on the Joomla Sandbox server.
I can't seem to re-produce the mentioned issue.