? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Aug 2020

Fixes #30518.

Summary of Changes

Fixes page break title when title attribute is placed after class attribute containing system-pagebreak class.

Testing Instructions

Use CodeMirror as editor.
Create a multipage article.
Change attribute order in page break's <hr> tag so title is after class, e.g.:

<p>Page 1.</p>
<hr alt="Page 2 Alt" class="system-pagebreak" title="Page 2 Title" />
<p>Page 2.</p>
<hr title="Page 3 Title" alt="Page 3 Alt" class="system-pagebreak" />
<p>Page 3.</p>

View Page 2 and Page 3 of the article.

Actual result BEFORE applying this Pull Request

Title from title attribute shown only on Page 3.

Expected result AFTER applying this Pull Request

Titles from title attribute are shown on both pages.

Documentation Changes Required

No.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar SharkyKZ SharkyKZ - open - 30 Aug 2020
avatar SharkyKZ SharkyKZ - change - 30 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2020
Category Front End Plugins
avatar SharkyKZ SharkyKZ - change - 30 Aug 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 30 Aug 2020
avatar SharkyKZ SharkyKZ - change - 30 Aug 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 30 Aug 2020
avatar SharkyKZ SharkyKZ - change - 30 Aug 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 30 Aug 2020
avatar Notebit Notebit - test_item - 30 Aug 2020 - Tested successfully
avatar Notebit
Notebit - comment - 30 Aug 2020

I have tested this item successfully on cac2ab1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30519.

avatar viocassel viocassel - test_item - 31 Aug 2020 - Tested successfully
avatar viocassel
viocassel - comment - 31 Aug 2020

I have tested this item successfully on cac2ab1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30519.

avatar alikon alikon - change - 31 Aug 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 31 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30519.

avatar zero-24
zero-24 - comment - 31 Aug 2020

Merging thanks

avatar zero-24 zero-24 - close - 31 Aug 2020
avatar zero-24 zero-24 - merge - 31 Aug 2020
avatar zero-24 zero-24 - change - 31 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-31 15:52:36
Closed_By zero-24
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment