Feeling Lucky
?
[#30489] - Helper/TagsHelper: fix strpos args order
- Closed
- 26 Aug 2020
- Medium
- Build: staging
- # 30489
- Diff
- quasilyte:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes the strpos call.
strpos() first argument is a haystack, not a needle.
strpos('x', $s) is identical to $s === 'x' which is probably not what we want here.
Testing Instructions
?
Actual result BEFORE applying this Pull Request
?
Expected result AFTER applying this Pull Request
?
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-26 15:05:15 |
| Closed_By | ⇒ | quasilyte | |
| Labels |
Added:
?
|
||
quasilyte
- comment
- 26 Aug 2020
Nope, if you already have a fix that does sound good to me.
Thanks. Do you want to test PR #26534 which already includes this fix?