Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30485] - [staging] Force lowercase for url language code

? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
26 Aug 2020

Pull Request for Issue #30184 (comment)

Summary of Changes

Multilingual sites.
Force sef (url language code) to lowercase if manually entered as uppercase which would throw a 404

Testing Instructions

Tests sef urls as for example
http://localhost:8888/installmulti/trunkgitnew/fr/blog/bienvenue-sur-votre-blog-fr-fr
change fr to FR to obtain
http://localhost:8888/installmulti/trunkgitnew/FR/blog/bienvenue-sur-votre-blog-fr-fr

you may get a 404 depending on your OS

patch and test again

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00
avatar infograf768 infograf768 - open - 26 Aug 2020
avatar infograf768 infograf768 - change - 26 Aug 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2020
Category ⇒ Front End Plugins
avatar richard67
richard67 - comment - 26 Aug 2020

@sebastienlapoux @manusfreedom As you have insisted so much on this change here, please spend the time to test it, and if it is ok for you please mark the test result in the issue tracker by following the link below, then using the "Test this" button, selecting the appropriate test result and then submitting. Thanks in advance.

https://issues.joomla.org/tracker/joomla-cms/30485

avatar manusfreedom manusfreedom - test_item - 26 Aug 2020 - Tested successfully
avatar manusfreedom
manusfreedom - comment - 26 Aug 2020

I have tested this item ✅ successfully on 2c25d35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30485.

avatar viocassel viocassel - test_item - 26 Aug 2020 - Tested successfully
avatar viocassel
viocassel - comment - 26 Aug 2020

I have tested this item ✅ successfully on 2c25d35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30485.

avatar infograf768 infograf768 - change - 27 Aug 2020
Labels Added: ?
avatar infograf768 infograf768 - change - 27 Aug 2020
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 27 Aug 2020

RTC as the last modification has no impact on tests. In fact it solves a situation where multibytes characters have been entered as url language code. (For example βω)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30485.

avatar rdeutz rdeutz - change - 27 Aug 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-08-27 07:13:31
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Aug 2020
avatar rdeutz rdeutz - merge - 27 Aug 2020
avatar manusfreedom manusfreedom - test_item - 27 Aug 2020 - Tested successfully
avatar manusfreedom
manusfreedom - comment - 27 Aug 2020

I have tested this item ✅ successfully on 1a7105e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30485.

Add a Comment

Login with GitHub to post a comment