[#30482] - [4.0] Convert jgrid if (icon) to switch (icon)
- Closed
- 31 Aug 2020
- Medium
- Build: 4.0-dev
- # 30482
- Diff
- N6REJ:jgrid-to-switch
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
converts multiple if statements into switch statements.
Testing Instructions
inspect administrator/index.php?option=com_content&view=articles
verify icons display properly using fas fa- in class names.
apply pr.
verify icons still use fas fa- in class names and display the same icons.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@infograf768 can you try your 3rd party app that had icon issues before and let me know if it still works?
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30482.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30482.
@infograf768 can you try your 3rd party app that had icon issues before and let me know if it still works?
Looks like this has no impact on com_localise.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-31 14:54:09 |
| Closed_By | ⇒ | N6REJ |
@hans2103 how's this look?