[#30464] - [4.0] Convert icon used for jgrid defaults to fas fa-
- Fixed in Code Base
- 25 Aug 2020
- Medium
- Build: 4.0-dev
- # 30464
- Diff
- N6REJ:circle
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
changes the icon used for grid defaults to fas fa-
Testing Instructions
go to administrator/index.php?option=com_menus&view=items&menutype=0main-menu-blog inspect circle icon
go to administrator/index.php?option=com_menus&view=items&menutype=mainmenu inspect home icon
apply pr
both icons should not change but inspect should show fas fa-
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries |
I have tested this item
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
Two things require attention: new PR ?
<span class="icon-trash" aria-hidden="true"></span>, should be <span class="fas fa-trash" aria-hidden="true"></span>
<span class="fas fa-fw fa-user-circle" aria-hidden="true"></span>, should be <span class="fas fa-user-circle fa-fw" aria-hidden="true"></span>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
| Labels |
Added:
?
?
|
||
Two things require attention: new PR ?
<span class="icon-trash" aria-hidden="true"></span>, should be<span class="fas fa-trash" aria-hidden="true"></span>
<span class="fas fa-fw fa-user-circle" aria-hidden="true"></span>, should be<span class="fas fa-user-circle fa-fw" aria-hidden="true"></span>
@N6REJ Could you make a PR?
Two things require attention: new PR ?
<span class="fas fa-fw fa-user-circle" aria-hidden="true"></span>, should be<span class="fas fa-user-circle fa-fw" aria-hidden="true"></span>This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
@sandewt does the fa-fw order really matter? or is this just a code style issue?
@sandewt does the fa-fw order really matter? or is this just a code style issue?
@N6REJ, I haved only looked at the source code of the browser view-source:https://localhost/joomla400-1/...
So I think, it's probably a code style issue.
[EDIT]
I now see that fa-fw is one time before it and the other time it is after it (by different classes).
See also Fixed Width Icons, link Font Awesome.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-25 09:20:51 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
Tks!
I have tested this item✅ successfully on aef5cdd
Tested successfully in Beta4-dev of 24 August.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30464.