[#30459] - [4.0] Fix mod_articles_latest
- Fixed in Code Base
- 25 Aug 2020
- Medium
- Build: 4.0-dev
- Easy Test
- # 30459
- Diff
- chmst:fix-articles-latest
User tests: Successful: Unsuccessful:
Pull Request for Issue #30445 .
Summary of Changes
Add a filter.condition for published articles to mod_articles_latest.
Testing Instructions
See the related #30445 .
Actual result BEFORE applying this Pull Request
Unpublished articles are shown in the Module mod_articles_latest.
Expected result AFTER applying this Pull Request
Only published articles are shown in the Module mod_articles_latest.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
| Easy | No | ⇒ | Yes |
It works like it should with this patch
I have tested this item
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
See comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.
It works like it should with this patch
@paternax Does it mean you have tested this pull resuest with success? If so, could you mark your test result on the issue tracker? Just follow this link https://issues.joomla.org/tracker/joomla-cms/30459 and then use the "Test this" button. Then select your appropriate test result ("succes" in this case) and submitt. Thanks in advance.
Is there any reason why state/condition filter is called filter.published in backend and filter.condition in backend?
$model->setState('filter.published', 1) DOESN'T WORK !
This following code works as alternative for: $model->setState('filter.condition', 1);
use Joomla\Component\Content\Administrator\Extension\ContentComponent;
...
$model->setState('filter.condition', ContentComponent::CONDITION_PUBLISHED);
[EDIT]
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.
@chmst So it should be filter.published. I guess #29235 just forgot to make replacements in frontend models. Maybe @bembelimen or @HLeithner knows.
Then it would be good th have this merged soon. And make complete change for the filter name.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.
Yes seems like we oversee this, it should be filter.published iirc there should be no condition keyword more in frontend.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.
@HLeithner So this one here is ok so far, and the rest can be fixed with a new PR?
@chmst Can you do that?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.
| Labels |
Added:
?
?
|
||
@richard67 I'll prepare a PR for that
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-25 16:59:16 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Merging this one as above then. Thanks!
Is there any reason why state/condition filter is called
filter.publishedin backend andfilter.conditionin backend?