NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 Aug 2020

Pull Request for Issue #30298
and #29285
and #29314

Summary of Changes

There is a known bug in Safari with the class overflow: hidden;
This Pr corrects the behavior for 2 aspects in core:
The switcher (edit cassiopea template style for example)
The Select Image button (edit category for example)
The switchers when editing user.

Testing Instructions

Test various places where these are used in Safari.
Confirm it does not break anything with other browsers.

After patch run npm ci

Actual result BEFORE applying this Pull Request

Screen Shot 2020-08-19 at 11 27 01

Screen Shot 2020-08-19 at 11 25 29

Expected result AFTER applying this Pull Request

Screen Shot 2020-08-19 at 11 10 19

Screen Shot 2020-08-19 at 11 30 48

Screen Shot 2020-08-19 at 11 09 38

Screen Shot 2020-08-19 at 11 34 29

@PhilETaylor

avatar infograf768 infograf768 - open - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2020
Category Administration Templates (admin) NPM Change Repository
avatar infograf768 infograf768 - change - 19 Aug 2020
The description was changed
avatar infograf768 infograf768 - edited - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
The description was changed
avatar infograf768 infograf768 - edited - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
The description was changed
avatar infograf768 infograf768 - edited - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
The description was changed
avatar infograf768 infograf768 - edited - 19 Aug 2020
avatar infograf768
infograf768 - comment - 19 Aug 2020

@wilsonge
drone is not happy with
Screen Shot 2020-08-19 at 11 57 20

Changing to
mask-image: radial-gradient(#fff, #000);

avatar infograf768 infograf768 - change - 19 Aug 2020
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 20 Aug 2020

@PhilETaylor @wilsonge
Please test. I have mixed results when Safari is used on IPAD or maybe other versions then the one I have here on Macintosh
Version 12.1.2 (12607.3.10)

avatar infograf768
infograf768 - comment - 20 Aug 2020

Modified to use instead
transform: translate3d(0, 0, 0);

avatar paternax
paternax - comment - 20 Aug 2020

Test with IPAD 13.5.1 - Switchers in edit Template style, Menu Item: link type and edit users are o.k.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30420.

avatar paternax
paternax - comment - 20 Aug 2020

Test with IPAD 13.5.1 - Switchers in edit Template style, Menu Item: link type and edit users are o.k.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30420.

avatar paternax paternax - test_item - 20 Aug 2020 - Tested successfully
avatar paternax
paternax - comment - 20 Aug 2020

I have tested this item successfully on 2b289c4

Test with IPAD IOS 13.5.1 - Switchers in edit Template style, Menu Item: link type and edit users are o.k.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30420.

avatar paternax
paternax - comment - 20 Aug 2020

I have tested this item successfully on 2b289c4

Test with IPAD IOS 13.5.1 - Switchers in edit Template style, Menu Item: link type and edit users are o.k.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30420.

avatar infograf768 infograf768 - alter_testresult - 20 Aug 2020 - paternax: Tested successfully
avatar Magnytu2 Magnytu2 - test_item - 20 Aug 2020 - Tested successfully
avatar Magnytu2
Magnytu2 - comment - 20 Aug 2020

I have tested this item successfully on 7b42e45

The display is correct on safari


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30420.

avatar infograf768 infograf768 - change - 20 Aug 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 20 Aug 2020
avatar laoneo laoneo - close - 20 Aug 2020
avatar laoneo laoneo - merge - 20 Aug 2020
avatar laoneo laoneo - change - 20 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-20 15:09:03
Closed_By laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 20 Aug 2020

Thanks!

Add a Comment

Login with GitHub to post a comment