[#30409] - [4.0][com_postinstall] cache 1 query result
- Fixed in Code Base
- 10 Jan 2021
- Medium
- Build: 4.0-dev
- # 30409
- Diff
- alikon:patch-122
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29950.
Summary of Changes
cache one query result
Testing Instructions
enable debug plugin
apply patch
go to control panel and look at the executed query number should be something like 30
refresh the page
now the query number should be something 29 ie one less
Actual result BEFORE applying this Pull Request
something like 30 queries
Expected result AFTER applying this Pull Request
something like 29 queries ie one less
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_postinstall |
| Labels |
Added:
?
|
||
Class imports are missing.
I get 37 Queries before and after applying the patch. This after reinstalling the nightly build today 2020-08-19.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
Cache needs to be cleaned when hiding messages.
I would not use caching here in the first place. But if you want to go that way, yes, refresh cache whenever it needs to be refreshed.
I would not use caching here in the first place.
can you elaborate a bit more , please....
i've thinked that postinstall messages would be a perfect fit for caching
added the cache clean after insert/update/delete
I have tested this item
I get 36 queries before and after applied the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
I get 36 queries before and after applied the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
Any progress on this? I checked that the patch does actually apply the code changes but I still get exactly the same number of queries with and without the patch. I assume this is something to do with the Post Installation Messages icon number in the title bar. Looking at that page still gives me no difference in the number of queries. Before test I pulled the joomla-cms source and merged it into my clone. Am I doing something wrong in the test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
Maybe missing in the testing instructions that caching must be enabled? Then it works as described.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30409.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-10 01:21:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@alikon MySQL system test failing. Not sure if it is related to your PR. Will investigate. Stay tuned.