? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
18 Aug 2020

Pull Request for Issue # .
as requested on the JBS Glip channel after the merge of #30157

Summary of Changes

change 'action' => 'joomlaupdate',

Testing Instructions

code review

avatar alikon alikon - open - 18 Aug 2020
avatar alikon alikon - change - 18 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2020
Category Front End Plugins
avatar ChristineWk ChristineWk - test_item - 18 Aug 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Aug 2020

I have tested this item successfully on 794bedb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30407.

avatar richard67
richard67 - comment - 18 Aug 2020

Not sure if a code review is enough. A valid btest would be to apply this patch on a clean staging branch and then update to the update package which has been built for this PR. The custom update URL and download packages for such an update can be found here at the bottom of this PR (if necessary use the "Show all checks" to expand the checks):
j3-pr-downloads

In this way you can do an update, and the patch of this PR is applied before and after the update.

Unfortunately I don't have time right now to test that.

avatar richard67 richard67 - test_item - 18 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 18 Aug 2020

I have tested this item successfully on 794bedb

Well, I could not resist to do a real test.

All ok.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30407.

avatar richard67 richard67 - change - 18 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 18 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30407.

avatar wilsonge wilsonge - merge - 18 Aug 2020
avatar wilsonge wilsonge - close - 18 Aug 2020
avatar wilsonge wilsonge - change - 18 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-18 15:55:05
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 18 Aug 2020

Thanks!

Add a Comment

Login with GitHub to post a comment