[#30401] - [4.0] Fix Alert multiple error display
- Fixed in Code Base
- 21 Aug 2020
- Medium
- Build: 4.0-dev
- # 30401
- Diff
- infograf768:4.0_alert_errors_installation
User tests: Successful: Unsuccessful:
Pull Request for Issue #30391
Summary of Changes
Installation Alerts are using the js. The <div> was misplaced.
I added a class but it is not necessary when using default core Installation.
Testing Instructions
Install a clean Joomla using a superuser password shorter than 12 characters
Patch, use NPM CI and install again
EDIT: To test multiple alerts in backend, add in Atum index.php
Factory::getApplication()->enqueueMessage('error message','error');
Factory::getApplication()->enqueueMessage('another long error message','error');
Factory::getApplication()->enqueueMessage('another very long error message','error');
Factory::getApplication()->enqueueMessage('warning message','warning');
Factory::getApplication()->enqueueMessage('warning message','warning');
Factory::getApplication()->enqueueMessage('notice message','notice');
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
Perhaps adding this divider line helps?
.alert-message:not(:first-of-type) {
border-top: 1px solid var(--alert-accent-color);
}
Looks good. Will test tomorrow.
It would look good for long messages in Installation but not really in admin.
In admin, multiple messages are really rare. And if they occur, it is worth to give them place. So it looks good for me.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Repository NPM Change | ⇒ | Administration Templates (admin) NPM Change Repository Layout Front End Templates (site) |
| Title |
|
||||||
In fact I succeeded adding the border.
Can be tested during installation as well as in back-end or frontend.
Updated Testing instructions.
Please @chmst and @brianteeman test again.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-21 10:01:15 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I am wondering if it is obvious that there are two separate error messages