Joomla! Issue Tracker | Joomla! CMS #30387 - [4.0] Child templates consistency

Fixed in Code Base
4 Sep 2020
Medium
Build: 4.0-dev
# 30387
Diff
dgrammatiko:4.0-dev-child-error

Pending

User tests: Successful: Unsuccessful:

dgrammatiko
16 Aug 2020

Pull Request supplementary for Issue #30384 .

Summary of Changes

This PR ensures that all the render() have the appropriate params (in particular templateInherits that acts as a switch for child templates)

Testing Instructions

Error pages render correctly (even for child templates, the previous PR was covering only the legacy mode)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge

cc0928e 16 Aug 2020

Handle templateInherits in all Apps correctly

dgrammatiko - open - 16 Aug 2020

dgrammatiko - change - 16 Aug 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 16 Aug 2020

Category

⇒

Libraries

richard67 - comment - 17 Aug 2020

API tests failing in Drone for this PR. Not sure, but it could be related to the PR. See https://ci.joomla.org/joomla/joomla-cms/34749/1/30

<!-- Argument 1 passed to Joomla\CMS\WebAsset\WebAssetRegistry::addTemplateRegistryFile() must be of the type string, null given, called in /tests/www/test-install/libraries/src/Error/Renderer/HtmlRenderer.php on line 55 (500 Whoops, looks like something went wrong.) -->

15b510e 17 Aug 2020

API getTemplate() should retrun object

dgrammatiko - change - 17 Aug 2020

Labels

Added: ?

dgrammatiko - comment - 17 Aug 2020

@richard67 if I got this right then this was a problem in the API Application and 15b510e should fix it

7d37f57 18 Aug 2020

Update ApiApplication.php

0cc5540 18 Aug 2020

Update InstallationApplication.php

joomla-cms-bot - change - 18 Aug 2020