[#30371] - [3.10] Fix broken closing tag for copyright in joomla.xml causing update from 3.10 to 4 fail completely
- Fixed in Code Base
- 14 Aug 2020
- Medium
- Build: 3.10-dev
- # 30371
- Diff
- richard67:3.10-dev-fix-broken-joomla-files-manifest-file
User tests: Successful: Unsuccessful:
Pull Request for Issue #29689 (comment).
Summary of Changes
Fix broken XML syntax caused by #29689 .
The update component uses the XML file to get the version from. simplexml_load_file breaks when loading that XML file at the beginning of an update to J4 (why ever that is done).
This causes the update to fail.
Testing Instructions
Can be merged on review.
I've checked that we don't have the same error anywhere else.
But if someone wants to see what such small mistake can cause:
- Update a current 3.10-dev or the last 3.10 nightly from tonight to J4 using the custom URL for the J4 nightlies.
Result: See section "Actual result BEFORE applying this Pull Request" below.
- Update a current 3.10-dev or the last 3.10 nightly from tonight to which the change of this PR has been applied to J4 using the custom URL for the J4 nightlies.
Result: See section "Expected result AFTER applying this Pull Request" below.
Actual result BEFORE applying this Pull Request
The database hasn't been updated at all.
Backend is completely broken.
Expected result AFTER applying this Pull Request
Except of the usual template error alert which can be ignored, all is fine.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Title |
|
||||||
| Title |
|
||||||
@HLeithner @nibra I have already checked if we have XML files with broken closing tag /copyright>. This is not the case. If anything else is broken I haven't checked. But the </copyright> will be ok in all XML files after this PR has been merged, so for that no need to check again.
richard@vmkubu02:~/lamp/public_html/joomla-cms-3.10-dev$ find ./ -type f -name "*\.xml" -exec grep -iHn "/copyright>" {} \; | grep -v "</copyright>"
./administrator/manifests/files/joomla.xml:7: <copyright>(C) 2019 Open Source Matters, Inc./copyright>
richard@vmkubu02:~/lamp/public_html/joomla-cms-3.10-dev$
And Joomla is really born in 2019?
Drone is passing at the first trial .. there must be something wrong ;-)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-14 09:32:00 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Merged on review. Don't talk to me about these dates...
Thanks for merge.
The testing instructions may be a documentation in case if this pops up as an issue later but before the next nightlies.
Thanks.
@nibra can you check if other xml files are broken too?