[#30369] - [4.0] Work around SQL template bug while upgrade
- Closed
- 15 Aug 2020
- Medium
- Build: 4.0-dev
- # 30369
- Diff
- Fedik:tmpl-update
User tests: Successful: Unsuccessful:
Pull Request for Issue #30333 #30363 #30365 and much others
Summary of Changes
Use asterisk to load template style, for AdministratorApplication
Testing Instructions
- Update a 4.0 Beta-1 or -2 or -3 to the latest 4.0 nightly build using the custom update URL or download package which can be found here: https://developer.joomla.org/nightly-builds.html.
Result: Update crashes with SQL error about not existing database column "s.inheritable".
- Update a 4.0 Beta-1 or -2 or -3 to the update package which has been built for this Pull Request. You can find the custom update URL and a download package when following the link "Details" for "Download" step in the automated testing results at the bottom of this PR. If necessary expand the "Show all checks".
Result: Update succeeds.
Actual result BEFORE applying this Pull Request
Update crashes
Expected result AFTER applying this Pull Request
Update is okay
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Sorry that's not a solution,
hm why, any drawback? I mean a "real"
Having this code till 5.0
till 5.0, no need longer
Sorry that's not a solution,
hm why, any drawback? I mean a "real"
?
Clean code instead of patchwork and workarounds that will be broken by the next workaround?
Having this code till 5.0
till 5.0, no need longer
?
That's would only be true if we have again a 4.10 (or what ever version) which need to be updated between 3.10 and 5.0. Which shouldn't be needed.
A clean code is good of course, but it not really a technical drawback.
And select s.* from ... is valid query statement, so no hidden hacks here.
I have seen worse
Well, about how long it should stay, it depend from how the update process will evolve.
If in next year someone will decide to rewrite update to isolated app, then the patch may be reviewed at that time.
I don't see how I can test this patch. My J4 Bet4-Dev site has already been updated so I can't just delete those two columns. I am not in a position to revert to yesterday. Sorry - just not enough experience.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30369.
I tested with an older J4 Install - the admin side works but the site throws a 500 error.
Those two columns are still not in the template_styles table.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30369.
Deleted successful test and changed comment on result of my test.
hm, I see, I thought that was reverted 3.10 backport , but it was 4.0 path,
this workaround does not make sense then :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-15 07:40:16 |
| Closed_By | ⇒ | Fedik |
Hello,
I've the same problem after install the actual joomla 4 version (beta5). I tried to replace the snippets like it shown here. That helps for the admin sites. Thanks a lot! All the backend-pages are working fine now, but the frontend page figures with the error like before: "Unknown column 'inheritable' in 'field list'".
You can see all the error report on my website: https://geschenkesuchen.com/
I'm not a programmer. Can someone help me?
Hi Richard, thanks a lot! Now all is working fine ;-)
@jonasreinsch333 If you have done changes in PHP code like in this PR here, revert those changes, they are not needed anymore after the SQL correction.
Thanks for the hint! I will try it.
Sorry that's not a solution, then better revert the child template pr or write a manual beta4 upgrade path description.
Having this code till 5.0 or 6.0 or what ever version shouldn't be the target.