[#30355] - [4.0] remove user from user group
- Fixed in Code Base
- 15 Sep 2020
- Medium
- Build: 4.0-dev
- # 30355
- Diff
- alikon:patch-117
User tests: Successful: Unsuccessful:
Pull Request for Issue #30324.
Summary of Changes
all credits goes to @veperr
Testing Instructions
- create a group, get groupId
- create a user, get userId
- add user to group
- try to remove user from group using:
UserHelper::removeUserFromGroup($userId, $groupId)
for the last point i've used the CLI command php cli/joomla.php user:removefromgroup
Actual result BEFORE applying this Pull Request
despite the successfull message from CLI command the user is not removed from that group ie it is not removed from the #__user_usergroup_map table
Expected result AFTER applying this Pull Request
the user is removed correctly from that table
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
See comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
Result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
For clarification, the usage that failed for me (as reported in issue 30324) was calling UserHelper::removeUserFromGroup($userId, $groupId) from PHP code.
I did not try the CLI.
One the other hand I wrote a minimal custom function that did the job:
private function removeUserFromGroup($userId, $groupId){
$user = User::getInstance($userId);
// $user = new User($userId);
// $user->load($userId);
$userGrps = Access::getGroupsByUser($userId, false);
unset($userGrps[array_search($groupId, $userGrps)]);
$user->groups = $userGrps;
$user->save();
// Store the data.
if (!$user->save())
{
$this->setError($user->getError());
return false;
}
return $user->id;
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
| Labels |
Added:
?
|
||
please retest
I have tested this item
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-15 11:27:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 127ef93
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.