? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
11 Aug 2020

Summary of Changes

This was missed in #30334.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 11 Aug 2020
avatar SharkyKZ SharkyKZ - change - 11 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2020
Category Front End Plugins
avatar ChristineWk ChristineWk - test_item - 11 Aug 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 11 Aug 2020

I have tested this item successfully on 9abaf78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

avatar richard67 richard67 - test_item - 11 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Aug 2020

I have tested this item successfully on 9abaf78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

avatar richard67 richard67 - change - 11 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

avatar richard67 richard67 - change - 11 Aug 2020
Labels Added: ? ?
avatar dgrammatiko
dgrammatiko - comment - 11 Aug 2020

FWIW the build tools should do this automatically, eg someone has to do the changes in the package.json (eg npm audit --fix) and then run npm install again. The whole idea was that the 3rd party dependencies should be a fairly easy maintenance task

avatar wilsonge wilsonge - close - 11 Aug 2020
avatar wilsonge wilsonge - merge - 11 Aug 2020
avatar wilsonge wilsonge - change - 11 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-11 10:24:50
Closed_By wilsonge
Labels
avatar wilsonge
wilsonge - comment - 11 Aug 2020

Yeah dunno whether the files weren't added or something else. the build tools do still work doing that though

Add a Comment

Login with GitHub to post a comment