I've restarted Drone 2 times now, and it always fails at the "javascript-cs" step, where it hasn't failed before, see https://ci.joomla.org/joomla/joomla-cms/34613/1/25. No idea if that is caused by this PR here.

Update: Maybe eslint comes with different default rules now?

@richard67 they are valid errors but unrelated to this pr

@brianteeman But why don't they fail on the current 4.0-dev branch?

No idea as the drone configuration is a mystery to me

No idea as the drone configuration is a mystery to me

Then we are at least two.

Just run npx eslint --fix "**/*.js", the errors are really minor here (multiple empty line, probably a changed rule in the eslint base config coming from airbnb-base)

probably a changed rule in the eslint base config coming from airbnb-base)

That was what I thought, too.

@brianteeman Could you do as suggested by Dimitris and add the fixed js to this PR? Thanks in advance.

i am doing that now

On Mon, 10 Aug 2020 at 12:53, dGrammatiko notifications@github.com wrote:

Just run npx eslint --fix "**/*.js", the errors are really minor here
(multiple empty line, probably a changed rule in the eslint base config
coming from airbnb-base)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#30334 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4MGVUK2QD72EYYBDQLR77NUTANCNFSM4PZ3M5OQ
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

I guess your PR replaces #30248 , right?

Solves #30319 .

I've closed the old PR #30248 and the issue #30319 .

PR with the cs fixes is #30335 .

@brianteeman I've merged the cs corrections by review. Could you update the branch of this PR to latest 4.0-dev so we can see if Drone passes now here? Thanks in advance.

Analysis4x/rips is complaining. I guess it's a false alarm, but it's continuously doing that, I've tried a few Drone job restarts. @SniperSister or @zero-24 Could you check that?

Finally after having restarted Drone some 150 or so times, all tests passed.

Sorry seems i missed to send the update here. We had an false positive and i rebooted drone. Great that it now passes.

I'll call the tests good enough for the dependency update whilst we're still in Beta

Thanks stranger ;)