? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
10 Aug 2020

Summary of Changes

Some optimizations in mod_menu.
Moved code so it's not executed on removed menu items.

Testing Instructions

Browse around the frontend.
Check that aria-current attribute in mod_menu appears like before.

avatar SharkyKZ SharkyKZ - open - 10 Aug 2020
avatar SharkyKZ SharkyKZ - change - 10 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2020
Category Modules Front End
avatar SharkyKZ SharkyKZ - change - 10 Aug 2020
Labels Added: ?
avatar ceford ceford - test_item - 10 Aug 2020 - Tested successfully
avatar ceford
ceford - comment - 10 Aug 2020

I have tested this item successfully on 877d80e

Confirmed - same instances of aria-current before and after applying patch. I deleted one menu item for this test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30328.

avatar Quy Quy - test_item - 10 Aug 2020 - Tested successfully
avatar Quy
Quy - comment - 10 Aug 2020

I have tested this item successfully on 877d80e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30328.

avatar Quy Quy - change - 10 Aug 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30328.

avatar wilsonge wilsonge - change - 10 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-10 21:30:02
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Aug 2020
avatar wilsonge wilsonge - merge - 10 Aug 2020
avatar wilsonge
wilsonge - comment - 10 Aug 2020

Thanks!

Add a Comment

Login with GitHub to post a comment