User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This Pull Request (PR) removes text-transform: uppercase;
from (S)CSS for com_menu items (.mod-menu li
) in the header section of the Cassiopeia template (.container-header
), i.e. from menus shown at the top on module positions "Menu" or "Search".
Having all menu items in uppercase letters makes the menu hard to read, e.g. for dyslexic people. As I've just learned it's an accessibility issue.
Create a menu with more than 1 item on the first level and at least one item having sub-items on the 2nd level.
Create a frontend module for that menu on one of the module positions on module positions "Menu" or "Search" and set Sub-menu Items
to Show
in the module settings.
Go to the front page and check the menu link texts.
Result: They are all in uppercase on all levels of the menu.
Apply the patch of this PR.
Run npm run build:css
if you have npm, or update to the update package built for this PR if you know how to do that.
Go again to the front page or if still there, do a forced reload so no cached css is used, and check again the menu link texts.
Result: They are on all menu levels as defined for that menu item, i.e. not capitalized anymore.
On all levels of menus shown in the header section, i.e. module positions "Menu" or "Search", the link texts are transformed into uppercase letters:
On all levels of menus shown in the header section, i.e. module positions "Menu" or "Search", the link texts are not transformed into uppercase letters:
Note: The ugly display of menus with more than one level is not subject of this PR. We should have some nice accessible menu with dropdowns.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Templates (site) NPM Change |
Thanks for the feedback, @brianteeman . I was surprised too that I did not find any old issue or PR for that.
Title |
|
I have tested this item
By code review.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
?
NPM Resource Changed
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-08 16:46:10 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Thanks for testing.
it is a massive a11y issue. No idea why the a11y team didnt spot that yet