? NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
8 Aug 2020

Pull Request for Issue # .

Summary of Changes

This Pull Request (PR) removes text-transform: uppercase; from (S)CSS for com_menu items (.mod-menu li) in the header section of the Cassiopeia template (.container-header), i.e. from menus shown at the top on module positions "Menu" or "Search".

Having all menu items in uppercase letters makes the menu hard to read, e.g. for dyslexic people. As I've just learned it's an accessibility issue.

Testing Instructions

  1. Create a menu with more than 1 item on the first level and at least one item having sub-items on the 2nd level.

  2. Create a frontend module for that menu on one of the module positions on module positions "Menu" or "Search" and set Sub-menu Items to Show in the module settings.

  3. Go to the front page and check the menu link texts.

Result: They are all in uppercase on all levels of the menu.

  1. Apply the patch of this PR.

  2. Run npm run build:css if you have npm, or update to the update package built for this PR if you know how to do that.

  3. Go again to the front page or if still there, do a forced reload so no cached css is used, and check again the menu link texts.

Result: They are on all menu levels as defined for that menu item, i.e. not capitalized anymore.

Actual result BEFORE applying this Pull Request

On all levels of menus shown in the header section, i.e. module positions "Menu" or "Search", the link texts are transformed into uppercase letters:

j4-menu-capitalization_1

Expected result AFTER applying this Pull Request

On all levels of menus shown in the header section, i.e. module positions "Menu" or "Search", the link texts are not transformed into uppercase letters:

j4-menu-capitalization_2

Note: The ugly display of menus with more than one level is not subject of this PR. We should have some nice accessible menu with dropdowns.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 8 Aug 2020
avatar richard67 richard67 - change - 8 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2020
Category Front End Templates (site) NPM Change
avatar richard67 richard67 - change - 8 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2020
avatar richard67 richard67 - change - 8 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2020
avatar richard67 richard67 - change - 8 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2020
avatar richard67 richard67 - change - 8 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2020
avatar brianteeman
brianteeman - comment - 8 Aug 2020

I don't know if that is not even an accessibility issue.

it is a massive a11y issue. No idea why the a11y team didnt spot that yet

avatar richard67
richard67 - comment - 8 Aug 2020

Thanks for the feedback, @brianteeman . I was surprised too that I did not find any old issue or PR for that.

avatar richard67 richard67 - change - 8 Aug 2020
Title
[4.0] Remove uppercase text transformation from menus in the header area of the Cassiopeia template
[4.0] [a11y] Remove uppercase text transformation from menus in the header area of the Cassiopeia template
avatar richard67 richard67 - edited - 8 Aug 2020
avatar richard67 richard67 - change - 8 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2020
avatar chmst chmst - test_item - 8 Aug 2020 - Tested successfully
avatar chmst
chmst - comment - 8 Aug 2020

I have tested this item successfully on d43b0c8

By code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30320.

avatar bonzani bonzani - test_item - 8 Aug 2020 - Tested successfully
avatar bonzani
bonzani - comment - 8 Aug 2020

I have tested this item successfully on d43b0c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30320.

avatar richard67 richard67 - change - 8 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30320.

avatar richard67 richard67 - change - 8 Aug 2020
Labels Added: ? ? NPM Resource Changed ?
avatar Quy Quy - change - 8 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-08 16:46:10
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 8 Aug 2020
avatar Quy Quy - merge - 8 Aug 2020
avatar richard67
richard67 - comment - 8 Aug 2020

Thanks for testing.

Add a Comment

Login with GitHub to post a comment