? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
7 Aug 2020

Fixes #30309.

Summary of Changes

Removes quoting from ordering columns since there could be multiple columns.
Remove unneeded escaped used on hardcoded values.
Fixes ambiguous column names.

Testing Instructions

Create Articles - Latest in administrator.
Set Order to Recently Modified First.
View the module in control panel.

Actual result BEFORE applying this Pull Request

Error:

Unknown column 'modified DESC, created' in 'order clause'

Expected result AFTER applying this Pull Request

Works.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 7 Aug 2020
avatar SharkyKZ SharkyKZ - change - 7 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2020
Category Administration com_banners com_content com_newsfeeds com_workflow Modules
avatar ChristineWk ChristineWk - test_item - 7 Aug 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 7 Aug 2020

I have tested this item successfully on ecd5605


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312.

avatar richard67 richard67 - test_item - 7 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 7 Aug 2020

I have tested this item successfully on ecd5605


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312.

avatar richard67 richard67 - change - 7 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312.

avatar richard67 richard67 - change - 7 Aug 2020
Labels Added: ? ?
avatar Quy Quy - change - 7 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-07 18:45:46
Closed_By Quy
Labels
avatar Quy Quy - close - 7 Aug 2020
avatar Quy Quy - merge - 7 Aug 2020

Add a Comment

Login with GitHub to post a comment